add support for keys #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
sethlyons
force-pushed
the
addkeys
branch
2 times, most recently
from
803c93e
to
525c08d
Compare
|
Thanks for this, but there are some minor issues with hashes. This is certainly one reason why in #54 an array was used : In ruby there is no guarantee for the order of a hash's keys, which is why there are these "sort_by" key everywhere. I'm not quite sure why you have added some, but removed others (views) and left some new ones out (keys values). I'll go ahead and merge #54 for now. Are you still interested in rebasing your other changes? If not, I can re-implement them. |
|
hi! honestly, this was so long ago i don't remember. if you have a list of changes you want me to make, i'm happy to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i also fixed spec/classes/bind_server_spec.rb. it was expecting
'restart' => '/sbin/service named reload', but the manifest hadservice named reload. the test fix is in a separate commit.