Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: with no SERVER_PASSWORD can still apply setting #281

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Fix: with no SERVER_PASSWORD can still apply setting #281

merged 4 commits into from
Feb 5, 2024

Conversation

win5923
Copy link
Contributor

@win5923 win5923 commented Feb 3, 2024

Choices

Test instructions

  1. Comment out the SERVER_PASSWORD or set it to an empty string.
  2. Open the game and check if the ServerPassword in PalWorldSettings.ini is set to an empty string.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

@win5923 win5923 marked this pull request as draft February 3, 2024 10:43
@win5923 win5923 marked this pull request as ready for review February 3, 2024 10:45
@win5923
Copy link
Contributor Author

win5923 commented Feb 3, 2024

Do I need to apply this setting to ADMIN_PASSWORD as well?

@Dashboy1998
Copy link
Contributor

Do I need to apply this setting to ADMIN_PASSWORD as well?

rcon-cli doesn't work with an empty password.
RCON protocol itself refuses all requests when no password is set.

If there is no admin password then you aren't able to become an admin: /adminpassword ""

scripts/start.sh Outdated Show resolved Hide resolved
@thijsvanloef
Copy link
Owner

@win5923 Will review tonight!

@thijsvanloef thijsvanloef self-requested a review February 5, 2024 10:12
Copy link
Owner

@thijsvanloef thijsvanloef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made some changes, but ready to merge

@thijsvanloef thijsvanloef merged commit 433b2a6 into thijsvanloef:main Feb 5, 2024
4 checks passed
@win5923 win5923 deleted the server_password_fix branch February 5, 2024 18:35
MusclePr pushed a commit to MusclePr/palworld-server-docker that referenced this pull request Jun 19, 2024
Fix: with no `SERVER_PASSWORD` can still apply setting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants