Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add pre-commit, molecule, github workflows + chore #2

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

juju4
Copy link

@juju4 juju4 commented Sep 9, 2023

Proposed changes

This implements continuous integration through

  • pre-commit: mostly client-side
  • molecule pipeline (default + github action) through docker
  • default-bare github action directly on image to test without docker+systemd limitations

This also includes chore to fix lint issues (ansible-lint, yamllint mostly).
Redhat platform is marked experimental as failing inside molecule docker and can't be tested bare in github workflows.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • Lint and unit tests pass locally with my changes (if applicable) - with this PR
  • I have run pre-commit (pre-commit in the repo) - added with PR too
  • I have added tests that prove my fix is effective or that my feature works - object of the PR
  • I have added necessary documentation (if appropriate) - no but feel free to suggest where this should go
  • Linked to the relevant github issue or github discussion - issues or discussions not opened in repo

@benjamin-thinkst
Copy link

@juju4 This looks great. When you get a moment could you rebase to avoid merge conflicts.

@juju4
Copy link
Author

juju4 commented Sep 16, 2023

upstream merge done

@theidiotyouyellat
Copy link

@juju4 This is awesome! Question on the .github/workflows/galaxy.yml: should it point to theidiotyouyellat.opencanary or would it make more sense to have thinkst.opencanary? Forgive my ignorance if this is a stupid question.

@juju4
Copy link
Author

juju4 commented Sep 30, 2023

galaxy.yml should match what is in meta
https://github.com/thinkst/ansible-role-opencanary/blob/master/meta/main.yml#L3
That's why I left it as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants