-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Feature: UI for crosschain modules #5399
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5399 +/- ##
==========================================
- Coverage 54.85% 54.83% -0.03%
==========================================
Files 1142 1142
Lines 60928 60985 +57
Branches 5140 5145 +5
==========================================
+ Hits 33424 33440 +16
- Misses 26777 26819 +42
+ Partials 727 726 -1
*This pull request uses carry forward flags. Click here to find out more.
|
size-limit report 📦
|
@GWSzeto could you reference a linear ticket in the description |
apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/cross-chain/page.tsx
Outdated
Show resolved
Hide resolved
const { contract } = info; | ||
|
||
if (contract.chain.id === localhost.id) { | ||
return <div>asd</div>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace the placeholder asd
with a descriptive message that communicates the localhost limitation to users, such as Cross-chain deployment is not available on localhost networks
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
This PR has been inactive for 30 days. It is now marked as stale and will be closed in 5 days if no further activity occurs. |
This PR has been inactive for 7 days. It is now marked as stale and will be closed in 2 days if no further activity occurs. |
https://linear.app/thirdweb/project/[modular-contracts]-op-interoperability-module-87740e1390a9/overview
PR-Codex overview
This PR primarily focuses on enhancing cross-chain functionalities and modular contract deployments within the
thirdweb
framework. It introduces new features, updates existing functions, and refines contract handling for better interoperability.Detailed summary
next-env.d.ts
.namehash.ts
to include type casting forresult
.getContractPageSidebarLinks.ts
.showSuperchainBridgeFieldset
function inmodular-contract-default-modules-fieldset.tsx
.modifiedProxyDeployedEvent
inProxyDeployed.ts
with a TODO comment.nonce
parameter toinstallPublishedModule
options ininstallPublishedModule.ts
.CROSS_CHAIN
category inexplore.ts
.deployPublished.ts
to support cross-chain and superchain interoperability.deploy-via-autofactory.ts
to handle cross-chain deployment logic.cross-chain/page.tsx
andcross-chain/data-table.tsx
.CustomContractForm
to conditionally handle superchain modules and transaction counts.DataTable
for displaying cross-chain deployment statuses and handling user inputs.