Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Feature: UI for crosschain modules #5399

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Conversation

GWSzeto
Copy link
Contributor

@GWSzeto GWSzeto commented Nov 12, 2024

https://linear.app/thirdweb/project/[modular-contracts]-op-interoperability-module-87740e1390a9/overview


PR-Codex overview

This PR primarily focuses on enhancing cross-chain functionalities and modular contract deployments within the thirdweb framework. It introduces new features, updates existing functions, and refines contract handling for better interoperability.

Detailed summary

  • Updated TypeScript documentation link in next-env.d.ts.
  • Modified namehash.ts to include type casting for result.
  • Added "Cross Chain" link in getContractPageSidebarLinks.ts.
  • Introduced showSuperchainBridgeFieldset function in modular-contract-default-modules-fieldset.tsx.
  • Implemented modifiedProxyDeployedEvent in ProxyDeployed.ts with a TODO comment.
  • Added nonce parameter to installPublishedModule options in installPublishedModule.ts.
  • Expanded CROSS_CHAIN category in explore.ts.
  • Enhanced deployPublished.ts to support cross-chain and superchain interoperability.
  • Updated deploy-via-autofactory.ts to handle cross-chain deployment logic.
  • Added new components and logic for cross-chain data handling in cross-chain/page.tsx and cross-chain/data-table.tsx.
  • Improved CustomContractForm to conditionally handle superchain modules and transaction counts.
  • Enhanced DataTable for displaying cross-chain deployment statuses and handling user inputs.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Nov 12, 2024

⚠️ No Changeset found

Latest commit: fba275c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 4:27pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 4:27pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Jan 14, 2025 4:27pm
wallet-ui ⬜️ Skipped (Inspect) Jan 14, 2025 4:27pm

Copy link

graphite-app bot commented Nov 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 12, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 41.93548% with 36 lines in your changes missing coverage. Please review.

Project coverage is 54.83%. Comparing base (23d8001) to head (fba275c).

Files with missing lines Patch % Lines
.../src/contract/deployment/deploy-via-autofactory.ts 25.80% 23 Missing ⚠️
...rdweb/src/extensions/prebuilts/deploy-published.ts 43.47% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5399      +/-   ##
==========================================
- Coverage   54.85%   54.83%   -0.03%     
==========================================
  Files        1142     1142              
  Lines       60928    60985      +57     
  Branches     5140     5145       +5     
==========================================
+ Hits        33424    33440      +16     
- Misses      26777    26819      +42     
+ Partials      727      726       -1     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from da94509
packages 52.47% <41.93%> (-0.03%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...xtensions/modules/common/installPublishedModule.ts 100.00% <100.00%> (ø)
packages/thirdweb/src/utils/ens/namehash.ts 90.00% <100.00%> (+1.76%) ⬆️
...rdweb/src/extensions/prebuilts/deploy-published.ts 80.79% <43.47%> (-3.52%) ⬇️
.../src/contract/deployment/deploy-via-autofactory.ts 58.82% <25.80%> (-13.78%) ⬇️

... and 4 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Nov 12, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.65 KB (0%) 913 ms (0%) 3.3 s (+30.11% 🔺) 4.2 s
thirdweb (cjs) 115.43 KB (0%) 2.4 s (0%) 5.4 s (-15.36% 🔽) 7.7 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 391 ms (+36.42% 🔺) 503 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 55 ms (-21.32% 🔽) 65 ms
thirdweb/react (minimal + tree-shaking) 19.21 KB (0%) 385 ms (0%) 542 ms (-28.76% 🔽) 926 ms

@gregfromstl
Copy link
Member

@GWSzeto could you reference a linear ticket in the description

@gregfromstl gregfromstl changed the title UI for crosschain modules [Dashboard] Feature: UI for crosschain modules Nov 13, 2024
const { contract } = info;

if (contract.chain.id === localhost.id) {
return <div>asd</div>;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace the placeholder asd with a descriptive message that communicates the localhost limitation to users, such as Cross-chain deployment is not available on localhost networks

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Copy link
Contributor

This PR has been inactive for 30 days. It is now marked as stale and will be closed in 5 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Dec 25, 2024
@github-actions github-actions bot closed this Dec 28, 2024
@GWSzeto GWSzeto reopened this Dec 29, 2024
@GWSzeto GWSzeto requested review from a team as code owners December 29, 2024 03:03
@github-actions github-actions bot removed the Stale label Dec 30, 2024
Copy link
Contributor

github-actions bot commented Jan 6, 2025

This PR has been inactive for 7 days. It is now marked as stale and will be closed in 2 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Jan 6, 2025
@github-actions github-actions bot closed this Jan 9, 2025
@kumaryash90 kumaryash90 reopened this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants