[SDK]: move autoConnect function into it's own standalone function #5889
+767
−217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 48a74ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
fix: import errors
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5889 +/- ##
==========================================
+ Coverage 54.85% 54.95% +0.09%
==========================================
Files 1142 1144 +2
Lines 60928 60971 +43
Branches 5140 5151 +11
==========================================
+ Hits 33424 33504 +80
+ Misses 26777 26740 -37
Partials 727 727
*This pull request uses carry forward flags. Click here to find out more.
|
feat: expose autoConnect function
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
gregfromstl
reviewed
Jan 6, 2025
|
This PR has been inactive for 7 days. It is now marked as stale and will be closed in 2 days if no further activity occurs. |
…n/tool-2697-add-js-autoconnect
refactor: move connection manager into an internal construct
joaquim-verges
approved these changes
Jan 14, 2025
ElasticBottle
added
the
merge-queue
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
https://linear.app/thirdweb/issue/TOOL-2697/add-js-autoconnect
Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
How to test
Unit tests, playground, etc.
PR-Codex overview
This PR focuses on refactoring the auto-connect functionality for wallets in the
thirdweblibrary, enhancing the separation of concerns and improving the structure of the code. It introduces a standaloneautoConnectfunction and updates various components to utilize it.Detailed summary
autoConnectfunction inpackages/thirdweb/src/wallets/connection/autoConnect.ts.useAutoConnectCoreto utilizeautoConnectCore.AutoConnectPropsto point to the new structure.autoConnectimplementation.