Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoother OAuth Cancellation Handling + EndSession Prefab_ConnectWallet Option #187

Merged
merged 2 commits into from
May 17, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented May 17, 2024

PR-Codex overview

The focus of this PR is to enhance browser functionality, add cancellation support, and improve error handling in the wallet UI.

Detailed summary

  • Added endSessionOnDisconnect option in Prefab_ConnectWallet
  • Implemented cancellation handling in browser operations
  • Improved error handling in browser and wallet UI classes

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

Test Results for Android

  1 files  ±0  15 suites  ±0   18m 20s ⏱️ + 9m 47s
 96 tests ±0  92 ✅  - 4  0 💤 ±0  4 ❌ +4 
100 runs  ±0  96 ✅  - 4  0 💤 ±0  4 ❌ +4 

For more details on these failures, see this check.

Results for commit c8354d1. ± Comparison against base commit 3c17230.

Copy link

Test Results for StandaloneLinux64

  1 files  ±0  15 suites  ±0   18m 10s ⏱️ + 10m 55s
 96 tests ±0  92 ✅  - 4  0 💤 ±0  4 ❌ +4 
100 runs  ±0  96 ✅  - 4  0 💤 ±0  4 ❌ +4 

For more details on these failures, see this check.

Results for commit c8354d1. ± Comparison against base commit 3c17230.

Copy link

Test Results for WebGL

  1 files  ±0  15 suites  ±0   18m 0s ⏱️ + 10m 3s
 96 tests ±0  92 ✅  - 4  0 💤 ±0  4 ❌ +4 
100 runs  ±0  96 ✅  - 4  0 💤 ±0  4 ❌ +4 

For more details on these failures, see this check.

Results for commit c8354d1. ± Comparison against base commit 3c17230.

Copy link

Test Results for iOS

  1 files  ±0  15 suites  ±0   21m 32s ⏱️ + 14m 23s
 96 tests ±0  91 ✅  - 5  0 💤 ±0  5 ❌ +5 
100 runs  ±0  95 ✅  - 5  0 💤 ±0  5 ❌ +5 

For more details on these failures, see this check.

Results for commit c8354d1. ± Comparison against base commit 3c17230.

@0xFirekeeper 0xFirekeeper merged commit 890e617 into main May 17, 2024
5 of 13 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/oauth-cancel branch May 17, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant