-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple singleton // Instance based classes #193
Conversation
Moving towards removing ThirdwebManager dependency for SDKs that want to wrap thirdweb. Also will make it easier to port .NET SDK into Unity SDK later.
Test Results for iOS 1 files ±0 16 suites +1 8m 19s ⏱️ +19s Results for commit 3d3fd7a. ± Comparison against base commit 7f62dbf. This pull request removes 2 and adds 8 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Test Results for Android 1 files ±0 16 suites +1 8m 9s ⏱️ +7s Results for commit 3d3fd7a. ± Comparison against base commit 7f62dbf. This pull request removes 2 and adds 8 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Test Results for WebGL 1 files ±0 16 suites +1 8m 15s ⏱️ +18s Results for commit 3d3fd7a. ± Comparison against base commit 7f62dbf. This pull request removes 2 and adds 8 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Test Results for StandaloneLinux64 1 files ±0 16 suites +1 7m 57s ⏱️ -12s Results for commit 3d3fd7a. ± Comparison against base commit 7f62dbf. This pull request removes 2 and adds 8 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
/codex do you even know what this pr is about |
@0xFirekeeper This PR involves several changes related to the
These changes aim to improve functionality, structure, and maintainability within the |
Moving towards removing ThirdwebManager dependency for SDKs that want to wrap thirdweb. Also will make it easier to port .NET SDK into Unity SDK later.
Removes old Authenticate and uses thirdweb auth backend based one only.
Removes Nethereum.SIWE, Nethereum.SIWE.Core, Nethereum.GnosisSafe
External and Common APIs affected:
Most internal APIs changed, ThirdwebManager Instances all removed except for WalletConnect ScriptableObject Load.
Some utils take in an extra parameter now, some uncommon utils removed.
Adds a couple basic tests for raw sdk initialization, will need to move some of the defaults logic out of ThirdwebManager to make it more user-friendly.
This PR also improves passing down rpc headers when instantiating a ThirdwebClient for readonly purposes, will speed up reads when available. Adds Utils to get headers and get web3.
PR-Codex overview
The focus of this PR is restructuring classes and improving wallet functionalities.
Detailed summary
Thirdweb.Pay
namespace