Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate function names =/= param count support #195

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Jun 5, 2024

PR-Codex overview

The focus of this PR is to refactor the code by introducing a new method GetFunctionMatchSignature in Utils.cs for finding functions in a contract based on signature.

Detailed summary

  • Added GetFunctionMatchSignature method in Utils.cs to find functions in a contract by matching signature
  • Replaced direct function retrieval with GetFunctionMatchSignature in Transaction.cs and Contract.cs files

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

github-actions bot commented Jun 5, 2024

Test Results for Android

  1 files  ±0   16 suites  ±0   8m 13s ⏱️ +22s
102 tests ±0  102 ✅ ±0  0 💤 ±0  0 ❌ ±0 
106 runs  ±0  106 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3389bae. ± Comparison against base commit 86c4d43.

Copy link

github-actions bot commented Jun 5, 2024

Test Results for StandaloneLinux64

  1 files  ±0   16 suites  ±0   8m 9s ⏱️ +21s
102 tests ±0  102 ✅ ±0  0 💤 ±0  0 ❌ ±0 
106 runs  ±0  106 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3389bae. ± Comparison against base commit 86c4d43.

Copy link

github-actions bot commented Jun 5, 2024

Test Results for iOS

  1 files  ±0   16 suites  ±0   8m 7s ⏱️ ±0s
102 tests ±0  102 ✅ ±0  0 💤 ±0  0 ❌ ±0 
106 runs  ±0  106 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3389bae. ± Comparison against base commit 86c4d43.

Copy link

github-actions bot commented Jun 5, 2024

Test Results for WebGL

  1 files  ±0   16 suites  ±0   8m 18s ⏱️ +43s
102 tests ±0  102 ✅ ±0  0 💤 ±0  0 ❌ ±0 
106 runs  ±0  106 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3389bae. ± Comparison against base commit 86c4d43.

@0xFirekeeper 0xFirekeeper merged commit 5456ad3 into main Jun 5, 2024
13 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/dupe-sig-support branch June 5, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant