Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebGL] Avoid all contract-abi calls when custom abi passed #196

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Jun 6, 2024

Speeds up contract fetches by 10x+


PR-Codex overview

This PR updates the thirdweb-unity-bridge.js file with changes related to hashing, encoding, and type validation functionalities.

Detailed summary

  • Added functions for hashing messages and encoding data
  • Updated type validation and error handling
  • Improved support for EIP712 domain encoding

The following files were skipped due to too many changes: Assets/WebGLTemplates/Thirdweb/lib/thirdweb-unity-bridge.js

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

github-actions bot commented Jun 6, 2024

Test Results for iOS

  1 files  ±0   16 suites  ±0   8m 15s ⏱️ +9s
102 tests ±0  102 ✅ ±0  0 💤 ±0  0 ❌ ±0 
106 runs  ±0  106 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 401a0ce. ± Comparison against base commit 5456ad3.

Copy link

github-actions bot commented Jun 6, 2024

Test Results for StandaloneLinux64

  1 files  ±0   16 suites  ±0   7m 53s ⏱️ -8s
102 tests ±0  102 ✅ ±0  0 💤 ±0  0 ❌ ±0 
106 runs  ±0  106 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 401a0ce. ± Comparison against base commit 5456ad3.

Copy link

github-actions bot commented Jun 6, 2024

Test Results for Android

  1 files  ±0   16 suites  ±0   8m 19s ⏱️ +6s
102 tests ±0  102 ✅ ±0  0 💤 ±0  0 ❌ ±0 
106 runs  ±0  106 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 401a0ce. ± Comparison against base commit 5456ad3.

Copy link

github-actions bot commented Jun 6, 2024

Test Results for WebGL

  1 files  ±0   16 suites  ±0   8m 12s ⏱️ -7s
102 tests ±0  102 ✅ ±0  0 💤 ±0  0 ❌ ±0 
106 runs  ±0  106 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 401a0ce. ± Comparison against base commit 5456ad3.

@0xFirekeeper 0xFirekeeper merged commit 2f1f691 into main Jun 6, 2024
13 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/webgl-caching branch June 6, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant