chore: sonar code smell fix

thisdot · Aug 17, 2023 · bf7aa9b · bf7aa9b
1 parent b22e823
commit bf7aa9b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/cra-rxjs-styled-components/src/constants/url.constants.ts b/cra-rxjs-styled-components/src/constants/url.constants.ts
@@ -85,17 +85,13 @@ export const ISSUES_PULLS_URL = ({
 		order: direction,
 	};
 	const queryStrings = convertObjectToQueryString(params);
+	const milestone_check =
+		typeof milestone === 'string'
+			? replaceEncodedSpaceWithPlus(encodeURIComponent(milestone))
+			: milestone;
 	const Q = `+is:${state}+is:${type}${
 		labels ? `+label:"${replaceSpaceWithPlus(labels)}"` : ''
-	}${
-		milestone
-			? `+milestone:"${
-					typeof milestone === 'string'
-						? replaceEncodedSpaceWithPlus(encodeURIComponent(milestone))
-						: milestone
-			  }"`
-			: ''
-	}`;
+	}${milestone ? `+milestone:"${milestone_check}"` : ''}`;
 	return `${GITHUB_URL_BASE}/search/issues?q=repo:${user}/${repo}${Q}&${queryStrings}`;
 };
 

diff --git a/cra-rxjs-styled-components/src/types/types.ts b/cra-rxjs-styled-components/src/types/types.ts
@@ -1,4 +1,3 @@
-// import { Issue } from "../components/issue/Issue/Issue.type";
 import { Issue } from '@/components/repo-issues/Issues/Issue.type';
 import { PullRequests } from '../components/pull-request/pull-request/PullRequest.type';