-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update readme for storybook issue #1628
Conversation
✅ Deploy Preview for angular-ngrx-scss canceled.
|
✅ Deploy Preview for angular-apollo-tailwind canceled.
|
✅ Deploy Preview for solidjs-tailwind canceled.
|
✅ Deploy Preview for cra-rxjs-styled-components canceled.
|
✅ Deploy Preview for nuxt-pinia-tailwind canceled.
|
✅ Deploy Preview for next-react-query-tailwind canceled.
|
✅ Deploy Preview for vue3-apollo-quasar canceled.
|
✅ Deploy Preview for remix-gql-tailwind canceled.
|
✅ Deploy Preview for svelte-kit-scss canceled.
|
✅ Deploy Preview for qwik-graphql-tailwind canceled.
|
✅ Deploy Preview for expo-zustand-styled-components canceled.
|
✅ Deploy Preview for solidstart-tanstackquery-tailwind-mod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for starter-dev-backend canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see also a check annotation in a file unrelated to this PR, but probably we can fix that here too:
in dynamicColor.ts
we should remove that any
in the getRGB
function.
we can typed that parameter like this:
function getRGB(c: string | number) {
return typeof c === 'string' ? parseInt(c, 16) : c;
}
This causes another set of errors. Not sure of the purpose of that function so won't want to touch it much. lol |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I found a small typo.
upgraded dependencies.... |
not sure why Solid Start params object have path with a "/" suddenly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nested folder navigation is broken, if you try to navigate inside a folder and then again inside another child folder, the second click doesn't work
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
addressed
Hi @AllStackDev1. 👋 Your PR has been approved and merged. 🎉 Thank you for your continued contributions to the starter.dev GitHub showcases repo. ❤️ Keep up the great work! |
Closes: #1620
Description
There are known issues with the way Storybook integrates with SolidStart framework. As such, most of what is in Storybook are the basic reusable components. This should be explained so that consumers are aware of these limitations with the integration.