Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme for storybook issue #1628

Merged
merged 24 commits into from
Aug 1, 2023
Merged

Conversation

AllStackDev1
Copy link
Contributor

@AllStackDev1 AllStackDev1 commented Mar 22, 2023

Closes: #1620

Description

There are known issues with the way Storybook integrates with SolidStart framework. As such, most of what is in Storybook are the basic reusable components. This should be explained so that consumers are aware of these limitations with the integration.

@netlify
Copy link

netlify bot commented Mar 22, 2023

Deploy Preview for angular-ngrx-scss canceled.

Name Link
🔨 Latest commit e0c753f
🔍 Latest deploy log https://app.netlify.com/sites/angular-ngrx-scss/deploys/64c92cc0a5f7580007c4f4a5

@netlify
Copy link

netlify bot commented Mar 22, 2023

Deploy Preview for angular-apollo-tailwind canceled.

Name Link
🔨 Latest commit e0c753f
🔍 Latest deploy log https://app.netlify.com/sites/angular-apollo-tailwind/deploys/64c92cc0689556000817deb4

@netlify
Copy link

netlify bot commented Mar 22, 2023

Deploy Preview for solidjs-tailwind canceled.

Name Link
🔨 Latest commit e0c753f
🔍 Latest deploy log https://app.netlify.com/sites/solidjs-tailwind/deploys/64c92cc07c42d20008620653

@netlify
Copy link

netlify bot commented Mar 22, 2023

Deploy Preview for cra-rxjs-styled-components canceled.

Name Link
🔨 Latest commit e0c753f
🔍 Latest deploy log https://app.netlify.com/sites/cra-rxjs-styled-components/deploys/64c92cc0813ec00008ad78ce

@netlify
Copy link

netlify bot commented Mar 22, 2023

Deploy Preview for nuxt-pinia-tailwind canceled.

Name Link
🔨 Latest commit e0c753f
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-pinia-tailwind/deploys/64c92cc0689556000817deb9

@netlify
Copy link

netlify bot commented Mar 22, 2023

Deploy Preview for next-react-query-tailwind canceled.

Name Link
🔨 Latest commit e0c753f
🔍 Latest deploy log https://app.netlify.com/sites/next-react-query-tailwind/deploys/64c92cc0c7886d0007bd02b2

@AllStackDev1 AllStackDev1 requested a review from Megio March 22, 2023 12:47
@netlify
Copy link

netlify bot commented Mar 22, 2023

Deploy Preview for vue3-apollo-quasar canceled.

Name Link
🔨 Latest commit e0c753f
🔍 Latest deploy log https://app.netlify.com/sites/vue3-apollo-quasar/deploys/64c92cc0d38737000821a5a7

@netlify
Copy link

netlify bot commented Mar 22, 2023

Deploy Preview for remix-gql-tailwind canceled.

Name Link
🔨 Latest commit e0c753f
🔍 Latest deploy log https://app.netlify.com/sites/remix-gql-tailwind/deploys/64c92cc0824b2000070aff71

@netlify
Copy link

netlify bot commented Mar 22, 2023

Deploy Preview for svelte-kit-scss canceled.

Name Link
🔨 Latest commit e0c753f
🔍 Latest deploy log https://app.netlify.com/sites/svelte-kit-scss/deploys/64c92cc0c0c590000842ad0f

@netlify
Copy link

netlify bot commented Mar 22, 2023

Deploy Preview for qwik-graphql-tailwind canceled.

Name Link
🔨 Latest commit e0c753f
🔍 Latest deploy log https://app.netlify.com/sites/qwik-graphql-tailwind/deploys/64c92cc05497e80008759139

@netlify
Copy link

netlify bot commented Mar 22, 2023

Deploy Preview for expo-zustand-styled-components canceled.

Name Link
🔨 Latest commit e0c753f
🔍 Latest deploy log https://app.netlify.com/sites/expo-zustand-styled-components/deploys/64c92cc00dcd4f000716c86f

@netlify
Copy link

netlify bot commented Mar 22, 2023

Deploy Preview for solidstart-tanstackquery-tailwind-mod ready!

Name Link
🔨 Latest commit e0c753f
🔍 Latest deploy log https://app.netlify.com/sites/solidstart-tanstackquery-tailwind-mod/deploys/64c92cc0d85707000800898a
😎 Deploy Preview https://deploy-preview-1628--solidstart-tanstackquery-tailwind-mod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Mar 22, 2023

Deploy Preview for starter-dev-backend canceled.

Name Link
🔨 Latest commit e0c753f
🔍 Latest deploy log https://app.netlify.com/sites/starter-dev-backend/deploys/64c92cc0fe6247000889f90a

Copy link
Contributor

@vyktoremario vyktoremario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment

solidstart-tanstackquery-tailwind-modules/README.md Outdated Show resolved Hide resolved
solidstart-tanstackquery-tailwind-modules/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Megio Megio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see also a check annotation in a file unrelated to this PR, but probably we can fix that here too:

in dynamicColor.ts we should remove that any in the getRGB function.
we can typed that parameter like this:

function getRGB(c: string | number) {
  return typeof c === 'string' ? parseInt(c, 16) : c;
}

@AllStackDev1
Copy link
Contributor Author

I see also a check annotation in a file unrelated to this PR, but probably we can fix that here too:

in dynamicColor.ts we should remove that any in the getRGB function. we can typed that parameter like this:

function getRGB(c: string | number) {
  return typeof c === 'string' ? parseInt(c, 16) : c;
}

This causes another set of errors.

image

Not sure of the purpose of that function so won't want to touch it much. lol

@sonarcloud
Copy link

sonarcloud bot commented Mar 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@honzikec honzikec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I found a small typo.

solidstart-tanstackquery-tailwind-modules/README.md Outdated Show resolved Hide resolved
@hdJerry hdJerry self-assigned this Jul 31, 2023
@hdJerry
Copy link
Contributor

hdJerry commented Jul 31, 2023

upgraded dependencies....

@hdJerry
Copy link
Contributor

hdJerry commented Jul 31, 2023

{
    "owner": "thisdot",
    "name": "starter.dev-github-showcases",
    "branch": "main",
    "path/": "angular-apollo-tailwind/projects"
}

not sure why Solid Start params object have path with a "/" suddenly.

Copy link
Contributor

@Megio Megio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nested folder navigation is broken, if you try to navigate inside a folder and then again inside another child folder, the second click doesn't work

@hdJerry hdJerry requested a review from Megio August 1, 2023 11:31
@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hdJerry hdJerry dismissed stale reviews from vyktoremario, honzikec, and kenslachtajr August 1, 2023 16:32

addressed

@hdJerry hdJerry merged commit e2688ac into main Aug 1, 2023
60 checks passed
@hdJerry hdJerry deleted the solidstart-readme-update-storybook branch August 1, 2023 16:34
@thisdot-bot
Copy link

Hi @AllStackDev1. 👋

Your PR has been approved and merged. 🎉

Thank you for your continued contributions to the starter.dev GitHub showcases repo. ❤️

Keep up the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[solidstart-tanstack-tailwind] Update README to include known issues with Storybook implementation
7 participants