Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cra rxjs search functionality #1914

Merged
merged 4 commits into from
Aug 14, 2023
Merged

Cra rxjs search functionality #1914

merged 4 commits into from
Aug 14, 2023

Conversation

hdJerry
Copy link
Contributor

@hdJerry hdJerry commented Aug 14, 2023

Implement search functionality

Background

In another ticket, a component was created with a search input field. The purpose of this ticket is to add the functionality to that input. A user should be able to write a query in the input, and the repositories listed on the page should be filtered based on that query after a short debounce time. If the user removes their query, either by clearing all the letters or clicking the X that should appear in the input, the repositories will be reset.

Acceptance

  • Search should filter all queries for any that match the search query
  • search works automatically after a debounce time
  • small X should show at end of input when user has added text, that when clicked will remove the query

Notes

@hdJerry hdJerry self-assigned this Aug 14, 2023
@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for cra-rxjs-styled-components ready!

Name Link
🔨 Latest commit e17cd9d
🔍 Latest deploy log https://app.netlify.com/sites/cra-rxjs-styled-components/deploys/64da078d6dd56a0008184959
😎 Deploy Preview https://deploy-preview-1914--cra-rxjs-styled-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for angular-ngrx-scss canceled.

Name Link
🔨 Latest commit e17cd9d
🔍 Latest deploy log https://app.netlify.com/sites/angular-ngrx-scss/deploys/64da078d82af3400089e770f

@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for angular-apollo-tailwind canceled.

Name Link
🔨 Latest commit e17cd9d
🔍 Latest deploy log https://app.netlify.com/sites/angular-apollo-tailwind/deploys/64da078d5059d50008ffbeaa

@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for solidjs-tailwind canceled.

Name Link
🔨 Latest commit e17cd9d
🔍 Latest deploy log https://app.netlify.com/sites/solidjs-tailwind/deploys/64da078db1678400089d2490

@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for vue3-apollo-quasar canceled.

Name Link
🔨 Latest commit e17cd9d
🔍 Latest deploy log https://app.netlify.com/sites/vue3-apollo-quasar/deploys/64da078df80f1f000890dfff

@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for nuxt-pinia-tailwind canceled.

Name Link
🔨 Latest commit e17cd9d
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-pinia-tailwind/deploys/64da078d6f238e000745f892

@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for remix-gql-tailwind canceled.

Name Link
🔨 Latest commit e17cd9d
🔍 Latest deploy log https://app.netlify.com/sites/remix-gql-tailwind/deploys/64da078dfb1124000800184a

@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for svelte-kit-scss canceled.

Name Link
🔨 Latest commit e17cd9d
🔍 Latest deploy log https://app.netlify.com/sites/svelte-kit-scss/deploys/64da078ddced190009e54591

@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for qwik-graphql-tailwind canceled.

Name Link
🔨 Latest commit e17cd9d
🔍 Latest deploy log https://app.netlify.com/sites/qwik-graphql-tailwind/deploys/64da078df9516400082b6b80

@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for starter-dev-backend canceled.

Name Link
🔨 Latest commit e17cd9d
🔍 Latest deploy log https://app.netlify.com/sites/starter-dev-backend/deploys/64da078dca9e33000864154f

@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for expo-zustand-styled-components canceled.

Name Link
🔨 Latest commit e17cd9d
🔍 Latest deploy log https://app.netlify.com/sites/expo-zustand-styled-components/deploys/64da078d7cb5740008d8fee0

@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for solidstart-tanstackquery-tailwind-mod canceled.

Name Link
🔨 Latest commit e17cd9d
🔍 Latest deploy log https://app.netlify.com/sites/solidstart-tanstackquery-tailwind-mod/deploys/64da078d05b6a80008c7528f

@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for next-react-query-tailwind canceled.

Name Link
🔨 Latest commit e17cd9d
🔍 Latest deploy log https://app.netlify.com/sites/next-react-query-tailwind/deploys/64da078dd709590008a277ad

@hdJerry hdJerry linked an issue Aug 14, 2023 that may be closed by this pull request
3 tasks
@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@Megio Megio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdJerry hdJerry merged commit 84d585a into main Aug 14, 2023
59 checks passed
@hdJerry hdJerry deleted the cra-rxjs-search-functionality branch August 14, 2023 11:13
@thisdot-bot
Copy link

Hi @hdJerry. 👋

Your PR has been approved and merged. 🎉

Thank you for your continued contributions to the starter.dev GitHub showcases repo. ❤️

Keep up the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cra-rxjs-sc] Implement search functionality
3 participants