Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRA-RXJS-SC] Fix PR API fetch #580

Merged
merged 6 commits into from
Aug 4, 2023
Merged

Conversation

kodejuice
Copy link
Contributor

@kodejuice kodejuice commented Sep 2, 2022

Closes: #539

  • On the Pull Request page, we should show 30 results but should be able to page for additional results
  • Fix the number displayed for open/closed

Loom video showing pagination: https://www.loom.com/share/5b8ff118c7b64b5eb89ffd17dd5d8a0f

@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-580.dbm2zhgk5abrj.amplifyapp.com

@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-580.d3sqkonra6x7y9.amplifyapp.com

@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-580.d1190gmno2hljg.amplifyapp.com

@kodejuice kodejuice linked an issue Sep 6, 2022 that may be closed by this pull request
@kodejuice kodejuice marked this pull request as ready for review September 7, 2022 09:11
@kodejuice kodejuice requested review from tyrelchambers and vyktoremario and removed request for tyrelchambers September 7, 2022 12:28
@hdJerry
Copy link
Contributor

hdJerry commented Aug 3, 2023

This is completely broken. I am currently Looking into it

@hdJerry hdJerry force-pushed the cra-rxjs-sc/fix/pr-api-fetch branch from 831e216 to 2846873 Compare August 3, 2023 18:32
@netlify
Copy link

netlify bot commented Aug 3, 2023

Deploy Preview for cra-rxjs-styled-components ready!

Name Link
🔨 Latest commit 2846873
🔍 Latest deploy log https://app.netlify.com/sites/cra-rxjs-styled-components/deploys/64cbf2c17f5f8900086560c3
😎 Deploy Preview https://deploy-preview-580--cra-rxjs-styled-components.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 3, 2023

Deploy Preview for angular-apollo-tailwind canceled.

Name Link
🔨 Latest commit 2846873
🔍 Latest deploy log https://app.netlify.com/sites/angular-apollo-tailwind/deploys/64cbf2c1884f5b000843bbf3

@netlify
Copy link

netlify bot commented Aug 3, 2023

Deploy Preview for angular-ngrx-scss canceled.

Name Link
🔨 Latest commit 2846873
🔍 Latest deploy log https://app.netlify.com/sites/angular-ngrx-scss/deploys/64cbf2c137ec0e00081e8264

@netlify
Copy link

netlify bot commented Aug 3, 2023

Deploy Preview for next-react-query-tailwind canceled.

Name Link
🔨 Latest commit 2846873
🔍 Latest deploy log https://app.netlify.com/sites/next-react-query-tailwind/deploys/64cbf2c152e8780007d36553

@netlify
Copy link

netlify bot commented Aug 3, 2023

Deploy Preview for solidjs-tailwind canceled.

Name Link
🔨 Latest commit 2846873
🔍 Latest deploy log https://app.netlify.com/sites/solidjs-tailwind/deploys/64cbf2c1125b1c0008d0171b

@netlify
Copy link

netlify bot commented Aug 3, 2023

Deploy Preview for vue3-apollo-quasar canceled.

Name Link
🔨 Latest commit 2846873
🔍 Latest deploy log https://app.netlify.com/sites/vue3-apollo-quasar/deploys/64cbf2c1b62f9a00086fab66

@netlify
Copy link

netlify bot commented Aug 3, 2023

Deploy Preview for nuxt-pinia-tailwind canceled.

Name Link
🔨 Latest commit 2846873
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-pinia-tailwind/deploys/64cbf2c1f2c0ad00081be0cc

@netlify
Copy link

netlify bot commented Aug 3, 2023

Deploy Preview for svelte-kit-scss canceled.

Name Link
🔨 Latest commit 2846873
🔍 Latest deploy log https://app.netlify.com/sites/svelte-kit-scss/deploys/64cbf2c1a2fa940009c10505

@netlify
Copy link

netlify bot commented Aug 3, 2023

Deploy Preview for expo-zustand-styled-components canceled.

Name Link
🔨 Latest commit 2846873
🔍 Latest deploy log https://app.netlify.com/sites/expo-zustand-styled-components/deploys/64cbf2c13ed8b30008655fe4

@netlify
Copy link

netlify bot commented Aug 3, 2023

Deploy Preview for qwik-graphql-tailwind canceled.

Name Link
🔨 Latest commit 2846873
🔍 Latest deploy log https://app.netlify.com/sites/qwik-graphql-tailwind/deploys/64cbf2c1884f5b000843bbf8

@netlify
Copy link

netlify bot commented Aug 3, 2023

Deploy Preview for starter-dev-backend canceled.

Name Link
🔨 Latest commit 2846873
🔍 Latest deploy log https://app.netlify.com/sites/starter-dev-backend/deploys/64cbf2c176a502000850ad9c

@netlify
Copy link

netlify bot commented Aug 3, 2023

Deploy Preview for remix-gql-tailwind canceled.

Name Link
🔨 Latest commit 2846873
🔍 Latest deploy log https://app.netlify.com/sites/remix-gql-tailwind/deploys/64cbf2c1fd1de00008ff8cee

@netlify
Copy link

netlify bot commented Aug 3, 2023

Deploy Preview for solidstart-tanstackquery-tailwind-mod canceled.

Name Link
🔨 Latest commit 2846873
🔍 Latest deploy log https://app.netlify.com/sites/solidstart-tanstackquery-tailwind-mod/deploys/64cbf2c1884f5b000843bbfd

@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hdJerry hdJerry merged commit d8dcb74 into main Aug 4, 2023
59 checks passed
@hdJerry hdJerry deleted the cra-rxjs-sc/fix/pr-api-fetch branch August 4, 2023 10:36
@thisdot-bot
Copy link

Hi @kodejuice. 👋

Congrats on your first PR being approved and merged! 🎉

Thank you for taking the time to contribute to the starter.dev GitHub showcases repo. ❤️

We look forward to your next contribution. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cra-rxjs-sc] Fix pull request API fetch
3 participants