Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update custom issue template backend tickets #1015

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kenslachtajr
Copy link

@kenslachtajr kenslachtajr commented Feb 10, 2023

Type of change

  • Documentation change
  • Bug fix

Summary of change

Checklist

  • These changes follow the contributing guidelines
  • This starter kit has been approved by the maintainers
  • Changes for this new starter kit are being pushed to an integration branch instead of main
  • All dependencies are version locked
  • This fix resolves #
  • I have verified the fix works and introduces no further errors

@kenslachtajr kenslachtajr self-assigned this Feb 10, 2023
@netlify
Copy link

netlify bot commented Feb 10, 2023

Deploy Preview for starter-dev failed.

Name Link
🔨 Latest commit 3a5a1e8
🔍 Latest deploy log https://app.netlify.com/sites/starter-dev/deploys/641d1de4d6c677000892f806

Copy link
Contributor

@Zelig880 Zelig880 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment here is linked to what we agree on the FE ticket

@@ -2,6 +2,11 @@

Having code style consistency is important for any project. A standardized set of options should be set that can be overwritten by the implementer at a later date.

- ESLint: Code formatting should be enforced via ESLint rules. Rules should be set to the strictest setting and enforced via CI. The standard rules for a stack should be selected and if there are specialized plugins, those should be utilized and appropriately tuned.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as the FE ticket changes. i think this is too strict.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are taken directly from the Specification. If we want to make this less strict, we should probably visit this in the Specification.

image

@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants