♻️ refactor: 페이지 별 컴포넌트, hook 이동 #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- /components/home -> /features/home/components - deadcode 삭제
- /components/meme -> /features/memes/components - deadcode 삭제 - feature간에 공통으로 쓰이는 컴포넌트는 /features/common 에 배치
- /components/mypage -> /features/mypage/components
- /components/collect -> /features/collect/components
- /components/search -> /features/search/components
- /components/tags -> /features/explore/tags/components - /components/keywords -> /features/explore/keywords/components - TagCategory 컴포넌트는 공통 컴포넌트로 /feature/common 으로 이동
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- /components/share -> /features/share/components
- /components/hocs -> /features/common/hocs
- /application/hooks/domain -> /features/common/hooks
- /application/hooks/domain -> /features/common/hooks
ojj1123
changed the title
SeieunYoo
approved these changes
Jul 16, 2023
This was referenced Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📮 관련 이슈
⛳️ 작업 내용
🌱 PR 포인트
refactor/issue-53마더 브랜치를 만든 후 이 브랜치에 RFC: FDA(Feature-Driven Architecture) 기반 폴더 구조 변경 및 react-query 구조 개선 #53 에 대한 작업을 모두 완료 한 후 최종적으로 develop으로refactor/issue-53브랜치를 merge 합니다./components/{page}->/features/{page}/components/application/hooks/domain->/features/{page}/hooks/features/common폴더TagCategory,MemeItem,useAuth,useChannelIO등 2개 이상의 페이지에서 사용하는 컴포넌트나 hook은/features/common폴더에서 관리