fix validate-chart scripts:

- clean-up temp yaml file - fix k8s version check - fix rke2-coredns templating - test for busybox image normally Signed-off-by: Thomas Ferrandiz <[email protected]>
thomasferrandiz · Jan 8, 2024 · addbc18 · addbc18
1 parent 9674104
commit addbc18
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/charts/chart_versions.yaml b/charts/chart_versions.yaml
@@ -17,7 +17,7 @@ charts:
   - version: 4.8.200
     filename: /charts/rke2-ingress-nginx.yaml
     bootstrap: false
-  - version: 2.11.100-build2023051511
+  - version: 2.11.100-build2023051513
     filename: /charts/rke2-metrics-server.yaml
     bootstrap: false
   - version: v4.0.2-build2023081106

diff --git a/scripts/build-images b/scripts/build-images
@@ -26,6 +26,7 @@ xargs -n1 -t docker image pull --quiet << EOF >> build/images-core.txt
     ${REGISTRY}/rancher/rke2-cloud-provider:${CCM_VERSION}
     ${REGISTRY}/rancher/mirrored-sig-storage-snapshot-controller:v6.2.1
     ${REGISTRY}/rancher/mirrored-sig-storage-snapshot-validation-webhook:v6.2.2
+    ${REGISTRY}/rancher/mirrored-library-busybox:1.36.1
 EOF
 
 xargs -n1 -t docker image pull --quiet << EOF > build/images-canal.txt

diff --git a/scripts/validate-charts b/scripts/validate-charts
@@ -51,15 +51,18 @@ check_system_registry() {
     chart_tmp=$3
 
     yaml_tmp=$(mktemp --suffix .yaml)
-    values="global.systemDefaultRegistry=my-registry,global.cattle.systemDefaultRegistry=my-registry,vCenter.clusterId=test-id"
+    values="global.systemDefaultRegistry=my-registry,global.cattle.systemDefaultRegistry=my-registry,vCenter.clusterId=test-id,global.clusterDNS=10.43.0.10\,2001:cafe:43::a"
     helm template test-chart --kube-version ${KUBERNETES_VERSION} --set $values $chart_tmp > $yaml_tmp;
 
     awk '$1 ~ /^image:/ {
-        if( $2 !~ /my-registry/ && $2 !~ busybox) {
+        if( $2 !~ /my-registry/ ) {
             print $2
         }
     }
     ' $yaml_tmp
+
+    #clean-up
+    rm -f $yaml_tmp
 }
 
 is_supported() {
@@ -110,7 +113,7 @@ check_airgap() {
     chart_tmp=$3
 
     yaml_tmp=$(mktemp --suffix .yaml)
-    values="vCenter.clusterId=test-id"
+    values="vCenter.clusterId=test-id,global.clusterDNS=10.43.0.10\,2001:cafe:43::a"
     helm template test-chart --kube-version ${KUBERNETES_VERSION} --set $values $chart_tmp > $yaml_tmp;
 
     chart_folder=$(mktemp -d)
@@ -120,7 +123,7 @@ check_airgap() {
         print $3 " " $5
     }
     ' $chart_folder/$chart_name/Chart.yaml `
-    if ! [ -z ${version_annotation} ]; then
+    if ! [[ -z ${version_annotation} ]]; then
         version_annotation=${version_annotation:0:-1}
         read lower_bound upper_bound <<< $version_annotation
 
@@ -138,11 +141,13 @@ check_airgap() {
     ' $yaml_tmp | \
     while read image
     do
-        [ "$image" = "busybox" ] && continue
         if ! grep -q $image scripts/build-images; then
             echo $image
         fi
     done
+
+    #clean-up
+    rm -f $yaml_tmp
 }
 
 declare -A NO_SYSTEM_REGISTRY