Add active_no_publication_date_error to crud.rs, make Work Status fie…

…ld required in View when work is Active

thoth-api/src/model/work/crud.rs

@@ -408,6 +408,7 @@ where
     Self: WorkProperties,
 {
     fn validate(&self) -> ThothResult<()> {
+        self.active_no_publication_date_error()?;
         self.withdrawn_date_error()?;
         self.no_withdrawn_date_error()?;
         self.withdrawn_date_before_publication_date_error()

thoth-api/src/model/work/mod.rs

@@ -326,6 +326,9 @@ impl WorkStatus {
     fn is_withdrawn(&self) -> bool {
         matches!(self, WorkStatus::WithdrawnFromSale)
     }
+    fn is_active(&self) -> bool {
+        matches!(self, WorkStatus::Active)
+    }
 }
 
 pub trait WorkProperties {
@@ -337,10 +340,25 @@ pub trait WorkProperties {
         self.work_status().is_withdrawn()
     }
 
+    fn is_active(&self) -> bool {
+        self.work_status().is_active()
+    }
+
     fn has_withdrawn_date(&self) -> bool {
         self.withdrawn_date().is_some()
     }
 
+    fn has_publication_date(&self) -> bool {
+        self.publication_date().is_some()
+    }
+
+    fn active_no_publication_date_error(&self) -> ThothResult<()> {
+        if self.is_active() && self.has_publication_date() {
+            return Err(ThothError::PublicationDateError);
+        }
+        Ok(())
+    }
+
     fn withdrawn_date_error(&self) -> ThothResult<()> {
         if !self.is_withdrawn() && self.has_withdrawn_date() {
             return Err(ThothError::WithdrawnDateError);

thoth-app/src/component/new_work.rs

@@ -459,6 +459,8 @@ impl Component for NewWorkComponent {
         let is_chapter = self.work.work_type == WorkType::BookChapter;
         let is_not_withdrawn = self.work.work_status
             != WorkStatus::WithdrawnFromSale;
+        let is_active = self.work.work_status
+            == WorkStatus::Active;
         html! {
             <>
                 <nav class="level">
@@ -525,6 +527,7 @@ impl Component for NewWorkComponent {
                         label = "Publication Date"
                         value={ self.work.publication_date.clone() }
                         oninput={ ctx.link().callback(|e: InputEvent| Msg::ChangeDate(e.to_value())) }
+                        required={ is_active }
                     />
                     <FormDateInput
                         label = "Withdrawn Date"

thoth-app/src/component/work.rs

@@ -579,6 +579,8 @@ impl Component for WorkComponent {
                 let is_chapter = self.work.work_type == WorkType::BookChapter;
                 let is_not_withdrawn = self.work.work_status
                     != WorkStatus::WithdrawnFromSale;
+                let is_active = self.work.work_status
+                    == WorkStatus::Active;
                 html! {
                     <>
                         <nav class="level">
@@ -653,6 +655,7 @@ impl Component for WorkComponent {
                                 label = "Publication Date"
                                 value={ self.work.publication_date.clone() }
                                 oninput={ ctx.link().callback(|e: InputEvent| Msg::ChangeDate(e.to_value())) }
+                                required = { is_active }
                             />
                             <FormDateInput
                                 label = "Withdrawn Date"

thoth-errors/src/lib.rs

@@ -85,6 +85,8 @@ pub enum ThothError {
         "Price values must be greater than zero. To indicate an unpriced Publication, omit all Prices."
     )]
     PriceZeroError,
+    #[error("Publication Date is required for an Active Work.")]
+    PublicationDateError,
     #[error("{0}")]
     RequestError(String),
     #[error("{0}")]