Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/583 add withdrawn date #594

Merged
merged 15 commits into from
Apr 25, 2024

Conversation

brendan-oconnell
Copy link
Contributor

@brendan-oconnell brendan-oconnell commented Apr 18, 2024

Addresses #583 by adding a new field to Work, withdrawn_date, applicable for work_status of OUT_OF_PRINT or WITHDRAWN_FROM_SALE.

@brendan-oconnell brendan-oconnell linked an issue Apr 18, 2024 that may be closed by this pull request
@brendan-oconnell brendan-oconnell changed the base branch from master to develop April 19, 2024 12:42
@brendan-oconnell brendan-oconnell marked this pull request as ready for review April 19, 2024 13:35
@brendan-oconnell brendan-oconnell requested a review from ja573 April 19, 2024 13:35
Copy link
Member

@ja573 ja573 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to require that withdrawn_date is set when setting the status

thoth-api/migrations/v0.12.3/up.sql Show resolved Hide resolved
…and withdrawn date < publication date; added validation errors for same constraints; made withdrawn date required on input form in component
@brendan-oconnell brendan-oconnell merged commit 965f46a into develop Apr 25, 2024
13 checks passed
@brendan-oconnell brendan-oconnell deleted the feature/583_add_withdrawn_date branch April 25, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Out-of-print / permanently withdrawn date
2 participants