Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

migrated project from setup.py to pyproject.toml #26

Merged

Conversation

theyashl
Copy link

Related Issues and Dependencies

Fixes: #24

This introduces a breaking change

  • No

This should yield a new module release

  • No

This Pull Request implements

Migrated the dependency of project metadata from setup.py to pyproject.toml

Description

Removed setup.py and introduced pyproject.toml file for project metadata tracking along with setup.cfg to implement sphinx integration.

@sesheta sesheta requested a review from harshad16 October 26, 2022 18:52
@sesheta sesheta added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 26, 2022
@sesheta
Copy link
Member

sesheta commented Oct 26, 2022

Hi @theyashl. Thanks for your PR.

I'm waiting for a thoth-station member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 26, 2022
@VannTen
Copy link
Member

VannTen commented Oct 27, 2022

/ok-to-test

@sesheta sesheta added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 27, 2022
@sesheta
Copy link
Member

sesheta commented Oct 27, 2022

@theyashl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
aicoe-ci/prow/pre-commit e9b081f link true /test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thank you for your contribution 100

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2022
@sesheta
Copy link
Member

sesheta commented Nov 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2022
@harshad16 harshad16 merged commit ab9b1a1 into thoth-station:master Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to pyproject.toml
5 participants