Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate setup.py to pyproject.toml (#311) #312

Conversation

ChandanChainani
Copy link
Contributor

Related Issues and Dependencies

Fixes: #311

@sesheta sesheta added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 10, 2022
@sesheta
Copy link
Member

sesheta commented Oct 10, 2022

Hi @ChandanChainani. Thanks for your PR.

I'm waiting for a thoth-station member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@VannTen
Copy link
Member

VannTen commented Oct 10, 2022

/ok-to-test

@sesheta sesheta added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 10, 2022
pyproject.toml Outdated Show resolved Hide resolved
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thank you for your contribution
just one change is needed, I think we had this typo earlier 😅

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2022
@sesheta sesheta removed the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2022
@ChandanChainani ChandanChainani requested review from harshad16 and removed request for KPostOffice October 17, 2022 17:50
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 💯
/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2022
@sesheta
Copy link
Member

sesheta commented Oct 17, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: harshad16
Once this PR has been reviewed and has the lgtm label, please assign sesheta for approval by writing /assign @sesheta in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16 harshad16 merged commit 51a8eeb into thoth-station:master Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to pyproject.toml
4 participants