Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce metrics for software stacks maintained by Kebechet #807

Merged

Conversation

pacospace
Copy link
Contributor

Signed-off-by: Francesco Murdaca [email protected]

Related Issues and Dependencies

Fixes: #791

@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 12, 2022
@pacospace pacospace requested a review from fridex January 12, 2022 11:02
Copy link
Contributor

@fridex fridex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor typo.

thoth/metrics_exporter/metrics.py Outdated Show resolved Hide resolved
Co-authored-by: Fridolín Pokorný <[email protected]>
@pacospace pacospace requested a review from fridex January 12, 2022 11:08
@codeclimate
Copy link

codeclimate bot commented Jan 12, 2022

Code Climate has analyzed commit e43a9c7 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@fridex fridex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏻

@sesheta
Copy link
Member

sesheta commented Jan 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2022
@sesheta sesheta merged commit bbbbd06 into thoth-station:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create metrics for number of stacks maintained by Kebechet
3 participants