Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Aggregate kebechet knowledge into single file #99

Closed
xtuchyna opened this issue Mar 12, 2021 · 4 comments
Closed

Aggregate kebechet knowledge into single file #99

xtuchyna opened this issue Mar 12, 2021 · 4 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@xtuchyna
Copy link
Member

Is your feature request related to a problem? Please describe.
Kebechet knowledge is being stored for every repo individually (#76). We need to merge that into a single file, so that overall statistics can be known (Kebechet is keeping ??? repos and etc.)

Describe the solution you'd like
Make mi-scheduler inspect all the knowledge tree after workflows are finished and merge data into

s3://thoth/data/{deployment-name}/thoth-sli-metrics/kebechet-update-manager/overall-{day_date}.json

Describe alternatives you've considered
Maybe make mi do this merging ?

@pacospace
Copy link

pacospace commented Mar 12, 2021

Is your feature request related to a problem? Please describe.
Kebechet knowledge is being stored for every repo individually (#76). We need to merge that into a single file, so that overall statistics can be known (Kebechet is keeping ??? repos and etc.)

Describe the solution you'd like
Make mi-scheduler inspect all the knowledge tree after workflows are finished and merge data into

s3://thoth/data/{deployment-name}/thoth-sli-metrics/kebechet-update-manager/overall-{day_date}.json

Describe alternatives you've considered
Maybe make mi do this merging ?

what about another component? another cronjob run every day, that check that knowledge and stores the aggreagated part again, something like thoth-station/slo-reporter#210 as kebechet is related to thoth? but not directly using SLO reporter if we are not interested in sending that aggregated knowledge also by email.

@goern wdyt?

@goern
Copy link
Member

goern commented Mar 13, 2021

sounds reasonable, I'm sure you'll find a good solution!

@sesheta
Copy link
Member

sesheta commented Jun 11, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 11, 2021
@xtuchyna
Copy link
Member Author

All relevant PRs merged, closin this one

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants