Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Mi scheduler/feature/kebechet merge #1160

Conversation

xtuchyna
Copy link
Member

@xtuchyna xtuchyna commented Apr 12, 2021

Related Issues and Dependencies

Related to thoth-station/mi-scheduler#99

This introduces a breaking change

  • Yes
  • No

Test or Stage Environment

  • Pull Requests added content to STAGE environment
  • Pull Requests to AICoE/aicoe-cd has been opened:

This Pull Request implements

New cronjob that schedules kebechet statistics merge

@xtuchyna
Copy link
Member Author

/kind WIP

@goern goern changed the title Mi scheduler/feature/kebechet merge WIP Mi scheduler/feature/kebechet merge Apr 12, 2021
@goern
Copy link
Member

goern commented Apr 12, 2021

/test all

1 similar comment
@harshad16
Copy link
Member

/test all

@xtuchyna
Copy link
Member Author

/retest

@xtuchyna
Copy link
Member Author

/assign @pacospace

@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 12, 2021
@xtuchyna
Copy link
Member Author

/cc @pacospace

@sesheta sesheta requested a review from pacospace April 12, 2021 14:38
@xtuchyna
Copy link
Member Author

/cc @fridex

@sesheta sesheta requested a review from fridex April 12, 2021 17:54
@xtuchyna
Copy link
Member Author

Hello @pacospace could you please have a look at this?

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all lgtm, just one change.


spec:
schedule: "00 22 * * *"
suspend: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you suspend all cronjob in base
and use the cronjob in individual overlays to suspend them.

please also include the cronjob mi-scheduler-kebechet-merge in all the overlays.

@sesheta
Copy link
Member

sesheta commented Apr 13, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign pacospace after the PR has been reviewed.
You can assign the PR to them by writing /assign @pacospace in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@goern
Copy link
Member

goern commented Apr 23, 2021

@xtuchyna any movement on this? what do we need to do to merge it?

@sesheta sesheta added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2021
@sesheta
Copy link
Member

sesheta commented Jun 6, 2021

@xtuchyna: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xtuchyna
Copy link
Member Author

xtuchyna commented Jun 8, 2021

#oops this was introduced and fixed in other PR that is already merged #1500
We can close this.
/close

@sesheta
Copy link
Member

sesheta commented Jun 8, 2021

@xtuchyna: Closed this PR.

In response to this:

#oops this was introduced and fixed in other PR that is already merged #1500
We can close this.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta closed this Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants