-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Mi scheduler/feature/kebechet merge #1160
WIP Mi scheduler/feature/kebechet merge #1160
Conversation
/kind WIP |
/test all |
1 similar comment
/test all |
/retest |
/assign @pacospace |
/cc @pacospace |
/cc @fridex |
Hello @pacospace could you please have a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all lgtm, just one change.
|
||
spec: | ||
schedule: "00 22 * * *" | ||
suspend: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you suspend all cronjob in base
and use the cronjob in individual overlays to suspend them.
please also include the cronjob mi-scheduler-kebechet-merge in all the overlays.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@xtuchyna any movement on this? what do we need to do to merge it? |
@xtuchyna: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
#oops this was introduced and fixed in other PR that is already merged #1500 |
@xtuchyna: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Related Issues and Dependencies
Related to thoth-station/mi-scheduler#99
This introduces a breaking change
Test or Stage Environment
AICoE/aicoe-cd
has been opened:This Pull Request implements
New cronjob that schedules kebechet statistics merge