Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Implement Kebechet Managers SLO/SLI metrics #572

Closed
7 of 15 tasks
Tracked by #560
xtuchyna opened this issue May 25, 2022 · 7 comments · Fixed by #574
Closed
7 of 15 tasks
Tracked by #560

Implement Kebechet Managers SLO/SLI metrics #572

xtuchyna opened this issue May 25, 2022 · 7 comments · Fixed by #574
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries.

Comments

@xtuchyna
Copy link
Member

xtuchyna commented May 25, 2022

Problem statement

Related to #560 (section Managers SLO/SLI)

As a maintainer,
I would like to have a look at dashboard with all Kebechet metrics

so that I can see which managers are used and performing well, which needs attention (slow responding time, critical number of rejected requests, and etc.) and which managers are not used (so even if they need attention, they can be of a low-priority).

Acceptance criteria

Create following metrics

  • Manager name
  • Manager % usage
    (comparisson to the overall number of repositories that have kebechet installed - if a manager has at least one reference in repository history, count it as a usage)

For

Extension

and also

  • Have a discussion on what other SLI/SLO metrics should be added, add all of the approved metrics here after

UPDATE after discussion (https://docs.google.com/document/d/1jz4j07Q8gkv9H-23BgOp_4qN3uI29JsuP-_kTKEj-e8/edit#bookmark=id.66cutwjvs6o2):

Additional SLI metrics:

  • work with usage count as with timestamps ( ? either each usage timestamp individually or a binned aggregation - e.g. monthly )
  • changes to the source code (e.g. update and version managers), furthermore for specific managers specific files
    (e.g. update manager and contributor comparison - how much did bot commit to the Pipfile in opposed to how much did contributor)

Additional SLO metrics:

  • response time (objective is to have some desired mean response time over all repositories)
  • response rate (e.g. objective is to have at least X % repositories satisfying response time under defined threshold Y seconds)
  • completion rate (ratio between created and closed by bot)
  • overall usage (e.g. update manager has objective to be used at least in X repositories)
  • repository specific (e.g. repo that has some changes in last month in source code should use version / update manager at least X times in month)
  • compare release frequency with version manager usage
@xtuchyna xtuchyna added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. labels May 25, 2022
@goern
Copy link
Member

goern commented Jul 26, 2022

@xtuchyna ping

@xtuchyna
Copy link
Member Author

xtuchyna commented Jul 26, 2022

@goern have a look at #574 (comment) 🙂

@xtuchyna
Copy link
Member Author

xtuchyna commented Aug 1, 2022

@goern @Gkrumbach07 so currently the update advise and version managers are implemented (look at PR to see data files example). I suggest splitting the Issue so we can track the features better. WDYT?

@goern
Copy link
Member

goern commented Aug 8, 2022

@xtuchyna ja, pls go ahead and split this issue

@goern
Copy link
Member

goern commented Aug 17, 2022

/sig user-experience

@sesheta sesheta added the sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. label Aug 17, 2022
@Gkrumbach07 Gkrumbach07 mentioned this issue Sep 20, 2022
@codificat codificat moved this to 🆕 New in Planning Board Sep 26, 2022
@Gkrumbach07 Gkrumbach07 moved this from 🆕 New to 🏗 In progress in Planning Board Oct 10, 2022
@Gkrumbach07 Gkrumbach07 added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Jan 24, 2023
@Gkrumbach07
Copy link
Member

Condensing issue due to inactivity
The following metrics for version, update, and advise managers are added:

  • advise
    • repository_usage_count
    • total_source_code_lines_changed_by_bot
    • percent_source_code_changes_by_bot
  • version
    • repository_usage_count
  • update
    • repository_usage_count
    • total_source_code_lines_changed_by_bot
    • percent_source_code_changes_by_bot
  • repositories_missing_issue_metric
  • repositories_missing_pull_request_metric

closing this issue and propagating uncompleted issues to parent EPIC
/close

@sesheta
Copy link
Member

sesheta commented Jan 30, 2023

@Gkrumbach07: Closing this issue.

In response to this:

Condensing issue due to inactivity
The following metrics for version, update, and advise managers are added:

  • advise
    • repository_usage_count
    • total_source_code_lines_changed_by_bot
    • percent_source_code_changes_by_bot
  • version
    • repository_usage_count
  • update
    • repository_usage_count
    • total_source_code_lines_changed_by_bot
    • percent_source_code_changes_by_bot
  • repositories_missing_issue_metric
  • repositories_missing_pull_request_metric

closing this issue and propagating uncompleted issues to parent EPIC
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta closed this as completed Jan 30, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Planning Board Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants