Add get active installations method #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtuchyna
added
the
kind/feature
sesheta
added
the
size/XS
|
NOTE: not yet tested, waiting for #2133 to be solved |
|
/hold |
sesheta
added
the
do-not-merge/hold
pacospace
reviewed
Dec 3, 2020
sesheta
added
size/S
xtuchyna
commented
Dec 3, 2020
|
/label sig/knowledge-graph |
pacospace
reviewed
Dec 4, 2020
This was referenced Dec 7, 2020
|
please rebase @xtuchyna |
sesheta
added
the
needs-rebase
sesheta
removed
the
needs-rebase
|
done @pacospace |
pacospace
approved these changes
Dec 14, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pacospace The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
approved
|
/retest |
pacospace
reviewed
Dec 17, 2020
| ['repository_foo_fullname', 'repository_bar_fullname', ...] | ||
| """ | ||
| with self._session_scope() as session: | ||
| active_installations = ( |
There was a problem hiding this comment.
@xtuchyna you can also use directly with_entities to receive directly the specific parameter.
active_installations_repos = (
session.query(KebechetGithubAppInstallations)
.filter(KebechetGithubAppInstallations.is_active.is_(True))
.with_entities(KebechetGithubAppInstallations.slug)
.all()
)
There was a problem hiding this comment.
This is better to do on the database side to avoid unnecessary serialization, rather than in python code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues and Dependencies
Related to both thoth-station/mi-scheduler#58
and thoth-station/common#1054 (comment)
This introduces a breaking change
This should yield a new module release
This Pull Request implements
New
def get_kebechet_github_installations_active(self) -> List[str]:methodDescription
The method returns the string list of all the repositories that have active kebechet installations