Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get or create github kebechet installation #2293

Merged
merged 1 commit into from
May 3, 2021
Merged

get or create github kebechet installation #2293

merged 1 commit into from
May 3, 2021

Conversation

KPostOffice
Copy link
Member

Function wasn't working if the entry didn't exist in the database. Here we create if it doesn't exist yet.

@sesheta sesheta requested a review from harshad16 April 30, 2021 14:23
@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 30, 2021
@KPostOffice KPostOffice force-pushed the f/g_or_c_github_installation branch from 214b42e to bfacccc Compare April 30, 2021 14:37
@goern
Copy link
Member

goern commented May 1, 2021

/lgtm
/assign @pacospace

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label May 1, 2021
@pacospace
Copy link
Contributor

Related-To: thoth-station/user-api#1181

pacospace
pacospace reviewed May 3, 2021
View reviewed changes
thoth/storages/graph/postgres.py Outdated
thoth_provenance_manager="thoth-provenance" in all_managers,
item = (
session.query(KebechetGithubAppInstallations)
.filter(KebechetGithubAppInstallations.installation_id == installation_id)
Copy link
Contributor

@pacospace pacospace May 3, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slug is unique in the database table and not installation_id, you cannot create two records with the same slug and different installation_id, because user can install, uninstall the app and a new installation_id would be created in that case (I assume this was the initial design decision by Sai)

@KPostOffice KPostOffice force-pushed the f/g_or_c_github_installation branch from bfacccc to f9647f5 Compare May 3, 2021 15:18
@sesheta
Copy link
Member

sesheta commented May 3, 2021

New changes are detected. LGTM label has been removed.

@sesheta sesheta removed the lgtm Indicates that a PR is ready to be merged. label May 3, 2021
pacospace
pacospace approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@pacospace pacospace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 💯

@sesheta
Copy link
Member

sesheta commented May 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacospace

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2021
@sesheta sesheta merged commit 2447651 into thoth-station:master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacospace pacospace pacospace approved these changes

@fridex fridex Awaiting requested review from fridex

@harshad16 harshad16 Awaiting requested review from harshad16

Assignees

@goern goern

@pacospace pacospace

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KPostOffice @goern @pacospace @sesheta