Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Thamos with a new flag to get the base image recommended #910

Closed
pacospace opened this issue Sep 16, 2021 · 14 comments
Closed

Extend Thamos with a new flag to get the base image recommended #910

pacospace opened this issue Sep 16, 2021 · 14 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@pacospace
Copy link
Contributor

pacospace commented Sep 16, 2021

Is your feature request related to a problem? Please describe.
See: AICoE/recommend-base-image-tutorial#1

Describe the solution you'd like
Extend Thamos with a new flag to get the base image recommended and provide it to the user.

Describe alternatives you've considered

Additional context

@pacospace pacospace added the triage/needs-information Indicates an issue needs more information in order to work on it. label Oct 1, 2021
@goern
Copy link
Member

goern commented Oct 5, 2021

/kind feature
/priority backlog

@sesheta sesheta added kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Oct 5, 2021
@pacospace
Copy link
Contributor Author

this is required for AICoE/recommend-base-image-tutorial#1 (comment)

@pacospace
Copy link
Contributor Author

hey @fridex do we need to add more here? I would like to add this feature to finish the last tutorial, wdyt?

@fridex
Copy link
Contributor

fridex commented Oct 13, 2021

I don't see any blockers to have this implemented.

@pacospace pacospace added triage/needs-information Indicates an issue needs more information in order to work on it. and removed triage/needs-information Indicates an issue needs more information in order to work on it. labels Oct 13, 2021
@pacospace
Copy link
Contributor Author

pacospace commented Oct 13, 2021

I don't see any blockers to have this implemented.

But at the moment the image is only provided in stack_info only from a boot pipeline unit, should we just iterate over stack_info results and look for ps-* URL links? If no images are identified, just warn the user.

@fridex
Copy link
Contributor

fridex commented Oct 13, 2021

It might be good to provide a generic mechanism for this in advised_manifest_changes so we can generalize the feature. Something like (rough design just to show the functionality):

advised_manifest_changes:
 - file: .thoth.yaml  # File that should be patched (can be also a buildconfig or so).
   patch:
     add: ...

@pacospace
Copy link
Contributor Author

It might be good to provide a generic mechanism for this in advised_manifest_changes so we can generalize the feature. Something like (rough design just to show the functionality):

advised_manifest_changes:
 - file: .thoth.yaml  # File that should be patched (can be also a buildconfig or so).
   patch:
     add: ...

sounds great, this would be part of a wrap for predictable stacks now right?

@fridex
Copy link
Contributor

fridex commented Oct 14, 2021

sounds great, this would be part of a wrap for predictable stacks now right?

Yes, only wrap pipeline units can add advised_manifest_changes as of now.

@sesheta
Copy link
Member

sesheta commented Jan 13, 2022

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 13, 2022
@sesheta
Copy link
Member

sesheta commented Feb 12, 2022

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@sesheta sesheta added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 12, 2022
@sesheta
Copy link
Member

sesheta commented Mar 14, 2022

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@sesheta
Copy link
Member

sesheta commented Mar 14, 2022

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta closed this as completed Mar 14, 2022
@pacospace pacospace reopened this Mar 15, 2022
@sesheta
Copy link
Member

sesheta commented Apr 14, 2022

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@sesheta
Copy link
Member

sesheta commented Apr 14, 2022

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta closed this as completed Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

4 participants