-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Thamos with a new flag to get the base image recommended #910
Comments
/kind feature |
this is required for AICoE/recommend-base-image-tutorial#1 (comment) |
hey @fridex do we need to add more here? I would like to add this feature to finish the last tutorial, wdyt? |
I don't see any blockers to have this implemented. |
But at the moment the image is only provided in |
It might be good to provide a generic mechanism for this in advised_manifest_changes:
- file: .thoth.yaml # File that should be patched (can be also a buildconfig or so).
patch:
add: ... |
sounds great, this would be part of a |
Yes, only wrap pipeline units can add |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. /close |
@sesheta: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Rotten issues close after 30d of inactivity. /close |
@sesheta: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Is your feature request related to a problem? Please describe.
See: AICoE/recommend-base-image-tutorial#1
Describe the solution you'd like
Extend Thamos with a new flag to get the base image recommended and provide it to the user.
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered: