Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Create recommend base image tutorial #1

Open
1 of 12 tasks
pacospace opened this issue Sep 3, 2021 · 17 comments
Open
1 of 12 tasks

Create recommend base image tutorial #1

pacospace opened this issue Sep 3, 2021 · 17 comments
Labels
kind/documentation Categorizes issue or PR as related to documentation. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@pacospace
Copy link

pacospace commented Sep 3, 2021

Is your feature request related to a problem? Please describe.
As Data Scientist,

I have a notebook for Computer Vision that I want to use in ODH.

As Data Scientist,

I have a stack with opencv and pytorch. I want to know which image should I use to run my Computer Vision Application.

High-level Goals
Have a tutorial on using a recommended base image for my ML application that can be run on Operate First with Meteor.

Describe the solution you'd like
Create steps in the tutorial.

Pre-requisite:

Steps:

Describe alternatives you've considered

Additional context
Related-To: thoth-station/core#308

Acceptance Criteria

  • The tutorial can run on Operate First.
@pacospace
Copy link
Author

/assign @pacospace

@harshad16
Copy link
Member

@harshad16
Copy link
Member

Ideas:

  • Having prescriptions (see the above link)
  • another use container analysis , lookup on the packages and recommend based on that .

@pacospace
Copy link
Author

pacospace commented Sep 9, 2021

pre-requisities

extra steps (not required)
to be converted to issues

  • create spike on automation of creation of the prescriptions for ps-stacks and main libraries involved (e.g PyTorch and open-cv for ps-cv)
  • next extension for Thamos to actually apply the base image recommended

@fridex
Copy link
Contributor

fridex commented Sep 13, 2021

pre-requisities

extra steps (not required)

to be converted to issues

  • create spike on automation of creation of the prescriptions for ps-stacks and main libraries involved (e.g PyTorch and open-cv for ps-cv)
  • next extension for Thamos to actually apply the base image recommended

Thanks for the meeting minutes write-up. First, we can start with prescriptions - they will be easy to write, maintain and can state the main packages for which we want to recommend the base image (e.g. pytorch stack).

Besides that, we should prioritize fix thoth-station/thoth-application#1788 as it is causing wrong data to be synced and associated with the container images we have in the database. It will unlock thoth-station/thoth-application#1788 and a possibility to query packages in container images we build in a separate pipeline unit that can recommend a base image with an exact/partial match for the stack. The prescriptions scenario is still applicable as this solution just extends what we offer to users.

On the user's side, we can have the mentioned flag that will apply changes to the .thoth.yaml and eventually .aicoe-ci.yaml file. We should revisit the current design of advised_manifest_changes to distinguish what data are propagated from the recommender, how they are recognized and subsequently applied to the corresponding files.

@pacospace
Copy link
Author

pacospace commented Sep 13, 2021

pre-requisities

extra steps (not required)
to be converted to issues

  • create spike on automation of creation of the prescriptions for ps-stacks and main libraries involved (e.g PyTorch and open-cv for ps-cv)
  • next extension for Thamos to actually apply the base image recommended

Thanks for the meeting minutes write-up. First, we can start with prescriptions - they will be easy to write, maintain and can state the main packages for which we want to recommend the base image (e.g. pytorch stack).

Thanks @fridex, let's do it!!

Besides that, we should prioritize fix thoth-station/thoth-application#1788 as it is causing wrong data to be synced and associated with the container images we have in the database.

Sounds good, @harshad16 what is ETA for the mentioned issue?

It will unlock thoth-station/thoth-application#1788 and a possibility to query packages in container images we build in a separate pipeline unit that can recommend a base image with an exact/partial match for the stack. The prescriptions scenario is still applicable as this solution just extends what we offer to users.

@fridex it will unlock thoth-station/thoth-application#1788 ?

Do we still want to use prescriptions in that case?

On the user's side, we can have the mentioned flag that will apply changes to the .thoth.yaml and eventually .aicoe-ci.yaml file. We should revisit the current design of advised_manifest_changes to distinguish what data are propagated from the recommender, how they are recognized and subsequently applied to the corresponding files.

Perfect!

@fridex
Copy link
Contributor

fridex commented Sep 13, 2021

@fridex it will unlock thoth-station/thoth-application#1788 ?

thoth-station/thoth-application#1788 will unlock thoth-station/adviser#1533 (also discussed in thoth-station/adviser#1943).

Do we still want to use prescriptions in that case?

Yes, they provide a different view of container images and Python packages shipped in them.

@pacospace
Copy link
Author

@fridex it will unlock thoth-station/thoth-application#1788 ?

thoth-station/thoth-application#1788 will unlock thoth-station/adviser#1533 (also discussed in thoth-station/adviser#1943).

Thanks, in the above comment was not linked, now I get it :)

Do we still want to use prescriptions in that case?

Yes, they provide a different view of container images and Python packages shipped in them.

Perfect, then we also want to introduce a mechanism to automatically create prescriptions from ps-stacks analysis.

@fridex
Copy link
Contributor

fridex commented Sep 13, 2021

Perfect, then we also want to introduce a mechanism to automatically create prescriptions from ps-stacks analysis.

A simple script that takes direct dependencies from Pipfiles and generates corresponding prescriptions out of them (as direct dependencies are the ones that in most cases define the container image use) should be good enough here. Later it could be plugged into a bigger workflow if necessary.

@pacospace
Copy link
Author

pacospace commented Sep 16, 2021

pre-requisities

extra steps (not required)
to be converted to issues

  • create spike on automation of creation of the prescriptions for ps-stacks and main libraries involved (e.g PyTorch and open-cv for ps-cv)
  • next extension for Thamos to actually apply the base image recommended

Issues created based on conversations with @fridex .

@pacospace
Copy link
Author

blocked by thoth-station/python#418 and quay issues.

@goern
Copy link
Member

goern commented Oct 5, 2021

/kind documentation
/priority critical-urgent

@sesheta sesheta added kind/documentation Categorizes issue or PR as related to documentation. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Oct 5, 2021
@pacospace
Copy link
Author

Depends-On: thoth-station/prescriptions#18523

@pacospace
Copy link
Author

pacospace commented Dec 22, 2021

Missing steps from Thoth side

Missing steps from Operate First side:

Tutorial specific:

  • create tutorial

@mayaCostantini
Copy link

/assign @mayaCostantini

@sesheta
Copy link
Contributor

sesheta commented Jun 8, 2022

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 8, 2022
@sesheta
Copy link
Contributor

sesheta commented Jul 8, 2022

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@sesheta sesheta added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 8, 2022
@mayaCostantini mayaCostantini added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Aug 4, 2022
@mayaCostantini mayaCostantini added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Dec 2, 2022
@mayaCostantini mayaCostantini removed their assignment Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/documentation Categorizes issue or PR as related to documentation. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

6 participants