Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding thoth solver f35-py310 image to imagestream in test overlay #2449

Conversation

Gregory-Pereira
Copy link
Member

Related Issues and Dependencies

Addresses: thoth-station/s2i-thoth#231
Related to: thoth-station/s2i-thoth#235
Depends on: thoth-station/solver#5151

Does this require new deployment ?

  • Deployment for Test and Stage AICoE/aicoe-cd and Prod operate-first/argocd-apps.

Description

Adding an ImageStream resource to the solver test overlay imagestream.yaml to stream the new fedora35-py310 solver image coming in solver pull 5151.

@sesheta sesheta requested review from codificat and fridex March 15, 2022 18:12
@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 15, 2022
@Gregory-Pereira Gregory-Pereira force-pushed the update-solver-imagestream-for-f35-py310 branch from b23ac71 to 18b71f4 Compare March 16, 2022 18:38
@harshad16 harshad16 added the sig/devsecops Categorizes an issue or PR as relevant to SIG DevSecOps. label Mar 17, 2022
@goern
Copy link
Member

goern commented Mar 21, 2022

looks like the repository on quay is missing.

/assign @Gregory-Pereira
/assign @harshad16

@harshad16
Copy link
Member

/lgtm
/approve

the image is now available: https://quay.io/repository/thoth-station/solver-fedora-35-py310?tab=tags

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2022
@sesheta
Copy link
Member

sesheta commented Mar 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2022
@sesheta sesheta merged commit c624042 into thoth-station:master Mar 21, 2022
@sesheta sesheta added this to the 2022.03.28 milestone Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. sig/devsecops Categorizes an issue or PR as relevant to SIG DevSecOps. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants