Using remote builds with buildbarn #3317
Open
+19
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using remote builds with buildbarn (bb-deployment with docker-compose)
Changes were made accordingly to existing project already using please, so they might be biased (wrong).
So, these changes are more like questions.
Ignore symlinks while checking outputs. This one seems a legit fix.
Use sri.checksums only if just one hash is available. bb-remote-asset currently only takes one hash and I could not find anything defining if multiple hashes are good or not.
Entrypoints checks on outputs considering OutputPaths. Currently we have multiple targets with entrypoints, and some have
outs
and otheroutput_dirs
. The ones withoutput_dirs
seems to forced to have these dirs in the entrypoints path.