Housekeeping #230

n-rodriguez · 2024-08-20T19:33:28Z

Hi there! This PR improves various things :

Move appraisal script to 'exe' directory (see: https://bundler.io/blog/2015/03/20/moving-bins-to-exe.html)
Add rspec and bundler binstub (to ease testing : you run bin/rspec instead of bundle exec rspec)
Disable RSpec monkey patching
Split bundler dir from gems build dir (to ease debug)

Note: this PR is based on #229 so you will need to merge #229 it first

Thank you!

hound · 2024-08-21T23:40:20Z

lib/appraisal/appraisal.rb

-          warn 'Your current version of Bundler does not support parallel installation. Please ' +
-            'upgrade Bundler to version >= 1.4.0, or invoke `appraisal` without `--jobs` option.'
+          warn "Your current version of Bundler does not support parallel installation. Please " +
+            "upgrade Bundler to version >= 1.4.0, or invoke `appraisal` without `--jobs` option."


Metrics/LineLength: Line is too long. [97/80]

hound · 2024-08-21T23:40:20Z

lib/appraisal/appraisal.rb

@@ -159,8 +161,8 @@ def bundle_options(options)
        if Utils.support_parallel_installation?
          options_strings << "--jobs=#{jobs}"
        else
-          warn 'Your current version of Bundler does not support parallel installation. Please ' +
-            'upgrade Bundler to version >= 1.4.0, or invoke `appraisal` without `--jobs` option.'
+          warn "Your current version of Bundler does not support parallel installation. Please " +


Metrics/LineLength: Line is too long. [98/80]

hound · 2024-08-21T23:40:20Z

lib/appraisal/appraisal.rb

        file.write lockfile_content.gsub(
          / #{current_directory}/,
-          " #{relative_path}",
+          " #{relative_path}"


Style/TrailingCommaInArguments: Put a comma after the last parameter of a multiline method call.

hound · 2024-08-21T23:40:21Z

lib/appraisal/bundler_dsl.rb

@@ -134,8 +136,7 @@ def dependencies_entry_for_dup
      @dependencies.for_dup
    end

-    %i[gits paths platforms groups source_blocks install_if].
-      each do |method_name|
+    %i[gits paths platforms groups source_blocks install_if].each do |method_name|


Metrics/LineLength: Line is too long. [82/80]

hound · 2024-08-21T23:40:21Z

lib/appraisal/bundler_dsl.rb

 require "appraisal/dependency_list"

 module Appraisal
  class BundlerDSL
    attr_reader :dependencies

-    PARTS = %w(source ruby_version gits paths dependencies groups
-               platforms source_blocks install_if gemspec)
+    PARTS = %w[source ruby_version gits paths dependencies groups


Style/MutableConstant: Freeze mutable objects assigned to constants.

hound · 2024-08-21T23:40:21Z

lib/appraisal/customize.rb

@@ -25,7 +27,7 @@ def self.customize(heading, gemfile)
        lockfile: "#{gemfile.send('gemfile_name')}.lock",
        lockfile_path: gemfile.send("lockfile_path"),
        relative_gemfile_path: gemfile.relative_gemfile_path,
-        relative_lockfile_path: "#{gemfile.relative_gemfile_path}.lock",
+        relative_lockfile_path: "#{gemfile.relative_gemfile_path}.lock"


Style/TrailingCommaInArguments: Put a comma after the last parameter of a multiline method call.

hound · 2024-08-21T23:40:21Z

lib/appraisal/gemspec.rb

@@ -22,7 +24,7 @@ def for_dup

    def exported_options
      @options.merge(
-        :path => Utils.prefix_path(@options[:path])
+        path: Utils.prefix_path(@options[:path])


Style/TrailingCommaInArguments: Put a comma after the last parameter of a multiline method call.

hound · 2024-08-21T23:40:21Z

lib/appraisal/utils.rb

 module Appraisal
  # Contains methods for various operations
  module Utils
    def self.support_parallel_installation?
-      Gem::Version.create(Bundler::VERSION) >= Gem::Version.create('1.4.0.pre.1')
+      Gem::Version.create(Bundler::VERSION) >= Gem::Version.create("1.4.0.pre.1")


Metrics/LineLength: Line is too long. [81/80]

hound · 2024-08-21T23:40:22Z

spec/acceptance/appraisals_file_bundler_dsl_compatibility_spec.rb


-    expect(content_of 'gemfiles/ruby_version.gemfile').to eq <<-Gemfile.strip_heredoc
+    expect(content_of("gemfiles/ruby_version.gemfile")).to eq <<-GEMFILE.strip_heredoc


Metrics/LineLength: Line is too long. [86/80]

hound · 2024-08-21T23:40:22Z

spec/acceptance/appraisals_file_bundler_dsl_compatibility_spec.rb


-    expect(content_of 'gemfiles/breakfast.gemfile').to eq <<-Gemfile.strip_heredoc
+    expect(content_of("gemfiles/breakfast.gemfile")).to eq <<-GEMFILE.strip_heredoc


Metrics/LineLength: Line is too long. [83/80]

hound · 2024-08-22T00:00:43Z

spec/acceptance/bundle_with_custom_path_spec.rb

-                      select { |gem| gem.include?(gem_name) }
+      installed_gem = Dir.glob("tmp/stage/#{path}/#{Gem.ruby_engine}/*/gems/*")
+                         .map    { |path| path.split("/").last }
+                         .select { |gem| gem.include?(gem_name) }


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Layout/MultilineMethodCallIndentation: Use 2 (not 19) spaces for indenting an expression in an assignment spanning multiple lines.

hound · 2024-08-22T00:00:43Z

spec/acceptance/bundle_with_custom_path_spec.rb

-                      map    { |path| path.split('/').last }.
-                      select { |gem| gem.include?(gem_name) }
+      installed_gem = Dir.glob("tmp/stage/#{path}/#{Gem.ruby_engine}/*/gems/*")
+                         .map    { |path| path.split("/").last }


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Layout/MultilineMethodCallIndentation: Use 2 (not 19) spaces for indenting an expression in an assignment spanning multiple lines.

hound · 2024-08-22T00:00:43Z

spec/acceptance/cli/install_spec.rb

-        "bundle install --gemfile='#{file('gemfiles/1.0.0.gemfile')}' " \
-        "--path #{file('vendor/appraisal')} --retry 1",
-      )
+      expect(output).to include("bundle install --gemfile='#{file('gemfiles/1.0.0.gemfile')}' --path #{file('vendor/appraisal')} --retry 1")


Metrics/LineLength: Line is too long. [140/80]

hound · 2024-08-22T00:00:43Z

spec/acceptance/cli/install_spec.rb

-        "bundle install --gemfile='#{file('gemfiles/1.0.0.gemfile')}' " \
-        "--retry 1 --full-index true"
-      )
+      expect(output).to include("bundle install --gemfile='#{file('gemfiles/1.0.0.gemfile')}' --retry 1 --full-index true")


Metrics/LineLength: Line is too long. [123/80]

hound · 2024-08-22T00:00:43Z

spec/acceptance/cli/install_spec.rb

+
+      expect(output).to     include("bundle install --gemfile='#{file('gemfiles/1.0.0.gemfile')}'")
+      expect(output).not_to include("bundle install --gemfile='#{file('gemfiles/1.0.0.gemfile')}' --jobs=0")
+      expect(output).not_to include("bundle install --gemfile='#{file('gemfiles/1.0.0.gemfile')}' --jobs=1")


Metrics/LineLength: Line is too long. [108/80]

hound · 2024-08-22T00:00:44Z

spec/acceptance/cli/run_spec.rb

-    write_file 'test.rb', 'puts "Running: #{$dummy_version}"'
-    write_file 'test with spaces.rb', 'puts "Running: #{$dummy_version}"'
+    run "appraisal install"
+    write_file "test.rb", 'puts "Running: #{$dummy_version}"'


Lint/InterpolationCheck: Interpolation in single quoted string detected. Use double quoted strings if you need interpolation.

hound · 2024-08-22T00:00:44Z

spec/acceptance/cli/update_spec.rb

-      expect(content_of 'gemfiles/dummy.gemfile.lock').to include 'dummy (1.0.1)'
-      expect(content_of 'gemfiles/dummy.gemfile.lock').to include 'dummy2 (1.0.0)'
+      expect(content_of("gemfiles/dummy.gemfile.lock")).to include "dummy (1.0.1)"
+      expect(content_of("gemfiles/dummy.gemfile.lock")).to include "dummy2 (1.0.0)"


Metrics/LineLength: Line is too long. [83/80]

hound · 2024-08-22T00:00:44Z

spec/acceptance/cli/update_spec.rb


-      expect(content_of 'gemfiles/dummy.gemfile.lock').to include 'dummy (1.0.1)'
-      expect(content_of 'gemfiles/dummy.gemfile.lock').to include 'dummy2 (1.0.0)'
+      expect(content_of("gemfiles/dummy.gemfile.lock")).to include "dummy (1.0.1)"


Metrics/LineLength: Line is too long. [82/80]

hound · 2024-08-22T00:00:44Z

spec/acceptance/cli/update_spec.rb

-      expect(content_of 'gemfiles/dummy.gemfile.lock').to include 'dummy (1.0.1)'
-      expect(content_of 'gemfiles/dummy.gemfile.lock').to include 'dummy2 (1.0.1)'
+      expect(content_of("gemfiles/dummy.gemfile.lock")).to include "dummy (1.0.1)"
+      expect(content_of("gemfiles/dummy.gemfile.lock")).to include "dummy2 (1.0.1)"


Metrics/LineLength: Line is too long. [83/80]

hound · 2024-08-22T00:00:44Z

spec/acceptance/cli/update_spec.rb


      expect(output).to include("gemfiles/dummy.gemfile bundle update")
-      expect(content_of 'gemfiles/dummy.gemfile.lock').to include 'dummy (1.0.1)'
-      expect(content_of 'gemfiles/dummy.gemfile.lock').to include 'dummy2 (1.0.1)'
+      expect(content_of("gemfiles/dummy.gemfile.lock")).to include "dummy (1.0.1)"


Metrics/LineLength: Line is too long. [82/80]

hound · 2024-08-22T00:05:02Z

spec/acceptance/gemfile_dsl_compatibility_spec.rb

-    expect(content_of "gemfiles/1.2.0.gemfile").to include('gem "bacon", "1.2.0"')
+    expect(content_of("gemfiles/1.0.0.gemfile")).to include('gem "bacon", "1.0.0"')
+    expect(content_of("gemfiles/1.1.0.gemfile")).to include('gem "bacon", "1.1.0"')
+    expect(content_of("gemfiles/1.2.0.gemfile")).to include('gem "bacon", "1.2.0"')


Metrics/LineLength: Line is too long. [83/80]

hound · 2024-08-22T00:05:03Z

spec/acceptance/gemfile_dsl_compatibility_spec.rb

-    expect(content_of "gemfiles/1.1.0.gemfile").to include('gem "bacon", "1.1.0"')
-    expect(content_of "gemfiles/1.2.0.gemfile").to include('gem "bacon", "1.2.0"')
+    expect(content_of("gemfiles/1.0.0.gemfile")).to include('gem "bacon", "1.0.0"')
+    expect(content_of("gemfiles/1.1.0.gemfile")).to include('gem "bacon", "1.1.0"')


Metrics/LineLength: Line is too long. [83/80]

hound · 2024-08-22T00:05:03Z

spec/acceptance/gemfile_dsl_compatibility_spec.rb

-    expect(content_of "gemfiles/1.0.0.gemfile").to include('gem "bacon", "1.0.0"')
-    expect(content_of "gemfiles/1.1.0.gemfile").to include('gem "bacon", "1.1.0"')
-    expect(content_of "gemfiles/1.2.0.gemfile").to include('gem "bacon", "1.2.0"')
+    expect(content_of("gemfiles/1.0.0.gemfile")).to include('gem "bacon", "1.0.0"')


Metrics/LineLength: Line is too long. [83/80]

hound · 2024-08-22T00:05:03Z

spec/acceptance/gemfile_dsl_compatibility_spec.rb


-    expect(content_of 'gemfiles/english.gemfile').to eq <<-Gemfile.strip_heredoc
+    expect(content_of("gemfiles/english.gemfile")).to eq <<-GEMFILE.strip_heredoc


Metrics/LineLength: Line is too long. [81/80]

hound · 2024-08-22T00:05:03Z

spec/acceptance/gemfile_dsl_compatibility_spec.rb


-    expect(content_of 'gemfiles/japanese.gemfile').to eq <<-Gemfile.strip_heredoc
+    expect(content_of("gemfiles/japanese.gemfile")).to eq <<-GEMFILE.strip_heredoc


Metrics/LineLength: Line is too long. [82/80]

hound · 2024-08-22T00:05:03Z