Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alt text to images #2487

Merged
merged 1 commit into from
May 23, 2024
Merged

Add alt text to images #2487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/views/layouts/_header_application_links.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@
<%= link_to my_account_path, id: "my_account_link", class: "avatar" do %>
<%= image_tag(
gravatar_url(current_user.email, size: "30"),
class: "avatar__image",
alt: "avatar image",
class: "avatar__image"
)%>
<% end %>
</li>
Expand Down
16 changes: 8 additions & 8 deletions app/views/pages/landing.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
receive mentorship from the best in the business.
</p>
<p>
<%= image_tag "marketing/many-faces.png" %>
<%= image_tag "marketing/many-faces.png", alt: "Many faces" %>
</p>
<p class="card__copy card__copy--centered">
Listen to their stories on our
Expand Down Expand Up @@ -81,7 +81,7 @@

<div class="conversation">
<%= image_tag "marketing/conversation-upcase.png",
class: "conversation__avatar" %>
class: "conversation__avatar", alt:"Upcase logo" %>

<div class="conversation__bubble">
<p>
Expand All @@ -104,7 +104,7 @@
</div>

<%= image_tag "marketing/conversation-avi.png",
class: "conversation__avatar" %>
class: "conversation__avatar", alt: "conversation avatar" %>
</div>
</div>

Expand All @@ -128,7 +128,7 @@
the full spectrum of skills needed to become an expert on a topic.
</p>

<%= image_tag "marketing/follow-expert-trails.png" %>
<%= image_tag "marketing/follow-expert-trails.png", alt:"Trail image" %>
</div>
</div>

Expand All @@ -143,7 +143,7 @@
mobile device.
</p>

<%= image_tag "marketing/new-videos-weekly.png" %>
<%= image_tag "marketing/new-videos-weekly.png", alt: "Video preview"%>
</div>
</div>
</div>
Expand All @@ -167,7 +167,7 @@
</span>

<div class="media-object testimonial__person">
<%= image_tag "marketing/testimonial-bryan.png" %>
<%= image_tag "marketing/testimonial-bryan.png", alt:"Code climate logo" %>

<span>
<span class="testimonial__person--name">Bryan Helmkamp</span></br>
Expand Down Expand Up @@ -238,7 +238,7 @@
</p>

<div class="media-object testimonial__person">
<%= image_tag "marketing/testimonial-matt.png" %>
<%= image_tag "marketing/testimonial-matt.png", alt: "Testimonial Person" %>

<span>
<span class="testimonial__person--name">Matt Sumner</span></br>
Expand All @@ -265,7 +265,7 @@
</p>

<div class="media-object testimonial__person">
<%= image_tag "marketing/testimonial-ralph.png" %>
<%= image_tag "marketing/testimonial-ralph.png", alt:"Testimonial Person" %>

<span>
<span class="testimonial__person--name">Ralph White</span></br>
Expand Down