-
-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds optional reply_to email reporter config option #794
Conversation
You should also update the CHANGELOG.md. |
oops, thanks I always forget that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Some feedback:
-
CHANGELOG.md
could havereply_to
in backticks (for formatting) - Should
Reply-To
only be set if it's non-empty andreply_to_email != from_email
(because you doself.config.get('reply_to', self.config['from'])
? - If you check non-empty,
self.config.get('reply_to', self.config['from'])
can becomeself.config.get('reply_to', '')
- Add
reply_to
to the default e-mail config inlib/urlwatch/storage.py
(empty string)
Thanks for the comments. I agree that adding the Reply-To header only if a user makes use of the I think that if the user enters in the same address for I took care of the change log and the default email config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! And I agree that specifying a reply_to
value should cause the header to be added, even if it's the same as the from
value, good point.
It can sometimes be useful to have a reply-to address different from the from address, especially when sending automated emails such as those generated by urlwatch. If email reports are being sent to a distribution list, a reply-to address of that list makes more sense than the (likely unmonitored) bot address.
This PR adds the
reply_to
config option for the email reporter. Note that theReply-To
header will now always be added to outgoing emails, but if thereply_to
option is missing, that header will simply be populated with the same value asFrom