Deribit: Add Subscription Configuration #1636
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1636 +/- ##
==========================================
+ Coverage 36.50% 36.53% +0.02%
==========================================
Files 414 414
Lines 179351 179087 -264
==========================================
- Hits 65472 65422 -50
+ Misses 106004 105791 -213
+ Partials 7875 7874 -1
|
14 tasks
gbjk
force-pushed
the
feature/deribit_sub_conf
branch
4 times, most recently
from
7a6cee6 to
3bb37fe
Compare
gbjk
force-pushed
the
feature/deribit_sub_conf
branch
from
04871d1 to
fa3520b
Compare
gbjk
force-pushed
the
feature/deribit_sub_conf
branch
from
fa3520b to
a6e200f
Compare
gloriousCode
approved these changes
Dec 5, 2024
Moved to exchange base by thrasher-corp#1472
Since I had to ask what this abbreviation meant, I think we should abandon it
Calling Setup twice would race on the assignment to this package var.
There was an option to just move the assignment to the package var declaration, but this
change improves the performance and allocations:
```
BenchmarkOptionPairToString-8 1000000 1239 ns/op 485 B/op 10 allocs/op
BenchmarkOptionPairToString2-8 3473804 656.2 ns/op 348 B/op 7 allocs/op
```
I've also removed the t.Run because even success the -v output from
tests would be very noisy, and I don't think we were getting any benefit
from it at all:
```
=== RUN TestOptionPairToString
=== PAUSE TestOptionPairToString
=== CONT TestOptionPairToString
=== RUN TestOptionPairToString/BTC-30MAY24-61000-C
=== PAUSE TestOptionPairToString/BTC-30MAY24-61000-C
=== RUN TestOptionPairToString/ETH-1JUN24-3200-P
=== PAUSE TestOptionPairToString/ETH-1JUN24-3200-P
=== RUN TestOptionPairToString/SOL_USDC-31MAY24-162-P
=== PAUSE TestOptionPairToString/SOL_USDC-31MAY24-162-P
=== RUN TestOptionPairToString/MATIC_USDC-6APR24-0d98-P
=== PAUSE TestOptionPairToString/MATIC_USDC-6APR24-0d98-P
=== CONT TestOptionPairToString/BTC-30MAY24-61000-C
=== CONT TestOptionPairToString/SOL_USDC-31MAY24-162-P
=== CONT TestOptionPairToString/ETH-1JUN24-3200-P
=== CONT TestOptionPairToString/MATIC_USDC-6APR24-0d98-P
--- PASS: TestOptionPairToString (0.00s)
--- PASS: TestOptionPairToString/BTC-30MAY24-61000-C (0.00s)
--- PASS: TestOptionPairToString/ETH-1JUN24-3200-P (0.00s)
--- PASS: TestOptionPairToString/SOL_USDC-31MAY24-162-P (0.00s)
--- PASS: TestOptionPairToString/MATIC_USDC-6APR24-0d98-P (0.00s)
```
( And that got worse with me adding more tests )
gbjk
force-pushed
the
feature/deribit_sub_conf
branch
from
a196533 to
4fa7bc3
Compare
shazbert
requested changes
Dec 12, 2024
| @@ -3266,11 +3268,79 @@ func setupWs() { | |||
| } | |||
| } | |||
|
|
|||
| func TestGenerateDefaultSubscriptions(t *testing.T) { | |||
| func TestGenerateSubscriptions(t *testing.T) { | |||
There was a problem hiding this comment.
Fixed gbjk@c3e5308ae
Was the result of the upstream fix to master to respect disabled websocket assets, and the test didn't know about that.
shazbert
requested changes
Dec 15, 2024
exchanges/deribit/deribit.go
Outdated
| initialDelimiter := currency.DashDelimiter | ||
| if subCodes[0] == "USDC" { | ||
| q := pair.Quote.String() | ||
| if q[:4] == "USDC" && len(q) > 11 { // Linear option |
There was a problem hiding this comment.
Suggested change
| if q[:4] == "USDC" && len(q) > 11 { // Linear option | |
| if strings.HasPrefix(q, "USDC") && len(q) > 11 { // Linear option |
Suggestion: Less panic at the disco.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deribit
Misc
Stacked Dependencies
Type of change