Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitfinex: Fix WS trade processing #1754

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bitfinex: Fix WS trade processing #1754

wants to merge 2 commits into from

Conversation

gbjk
Copy link
Collaborator

@gbjk gbjk commented Dec 18, 2024 •
edited
Loading

  • Bitfinex
    • Fixes exchange Bitfinex websocket error - unhandled WS trade update event:
    • Add tests for TestWSAllTrades
    • Add handling for public marginFunding trades
    • Fix idiosyncratic naming using TestWs instead of TestWS
    • Fix naming for wsTradeUpdated ( was wsTradeExecutionUpdate )
    • Fix trades not going to DataHandler unless SaveTrade was enabled
    • Enable tradeFeed for tests
  • Linter
    • Disables shadow checks for err and ctx. Advocated this before, but had my fill of stylecheck (correctly, IMO) fighting with shadow over this rule. This isn't strictly necessary, but it's nearly christmas again.

Fixes #1746
Progresses #1323 with a prototype

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@gbjk
Bitfinex: Fix WS trade processing
7d4be35 
* Add handling for funding trades

Fixes thrasher-corp#1746
@gbjk gbjk added bug review me This pull request is ready for review labels Dec 18, 2024
@gbjk gbjk self-assigned this Dec 18, 2024
@gbjk gbjk force-pushed the bugfix/bitfinex_ws_trade branch from 89cbb66 to 0dd865c Compare December 18, 2024 07:29
@gbjk
Linter: Disable shadow linting for ctx and err
cb416cc 
It's been a year, and I'm still getting caught out by govet demanding I
don't shadow a var I was deliberately shadowing.
Made worse by an increase in clashes with stylecheck when they both want
opposite things on the same line.
@gbjk gbjk force-pushed the bugfix/bitfinex_ws_trade branch from 0dd865c to cb416cc Compare December 19, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrasher- thrasher- Awaiting requested review from thrasher-

@gloriousCode gloriousCode Awaiting requested review from gloriousCode

@shazbert shazbert Awaiting requested review from shazbert

At least 3 approving reviews are required to merge this pull request.

Assignees

@gbjk gbjk

Labels
bug review me This pull request is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bitfinex: Fix WS Trade stream erroring
1 participant
@gbjk