Add back the SystemExit

thread · May 13, 2022 · 0f2e9aa · 0f2e9aa
1 parent 10cbbc6
commit 0f2e9aa
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/pipelinewise/cli/pipelinewise.py b/pipelinewise/cli/pipelinewise.py
@@ -1316,7 +1316,7 @@ def stop_tap(self, sig=None, frame=None):
             self.logger.error(
                 'No pidfile found at %s. Tap does not seem to be running.', pidfile_path
             )
-            return
+            sys.exit(1)
 
         # Terminate child processes
         try:

diff --git a/tests/units/cli/test_cli.py b/tests/units/cli/test_cli.py
@@ -624,8 +624,7 @@ def test_command_stop_tap(self):
             time.sleep(5)
 
             # Send the stop_tap command
-            with pytest.raises(SystemExit):
-                pipelinewise.stop_tap()
+            pipelinewise.stop_tap()
 
         # Should not have any remaining Pipelinewise related linux process
         for proc in psutil.process_iter(['cmdline']):