test22_use_Vikram_anya3_finally_correct_image

- also fix max_items_eval
threestudio-project · Jul 7, 2023 · 8097f02 · 8097f02
1 parent f95c771
commit 8097f02
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 4 deletions.
diff --git a/configs/experimental/imagecondition_zero123nerf.yaml b/configs/experimental/imagecondition_zero123nerf.yaml
@@ -108,7 +108,7 @@ system:
     min_step_percent: [0, 0.03, 0.02, 2000]  # (start_iter, start_val, end_val, end_iter)
     #max_step_percent: 0.6
     max_step_percent: [0, 0.3, 0.3, 2000]
-    max_items_to_save: 1
+    max_items_eval: 1
 
     # Vikram changes:
     # guidance_scale: 100

diff --git a/configs/zero123.yaml b/configs/zero123.yaml
@@ -111,7 +111,7 @@ system:
     cond_azimuth_deg: ${data.default_azimuth_deg}
     cond_camera_distance: ${data.default_camera_distance}
     guidance_scale: 3.0
-    max_items_to_save: 4
+    max_items_eval: 4
 
     min_step_percent: [0, 0.4, 0.2, 200]  # (start_iter, start_val, end_val, end_iter)
     max_step_percent: [0, 0.85, 0.5, 200]

diff --git a/threestudio/models/guidance/stable_diffusion_guidance.py b/threestudio/models/guidance/stable_diffusion_guidance.py
@@ -545,7 +545,7 @@ def guidance_eval(
         imgs_1orig = self.decode_latents(pred_1orig).permute(0, 2, 3, 1)
 
         latents_final = []
-        for b, i in enumerate(idxs[:max_items]):
+        for b, i in enumerate(idxs[:bs]):
             latents = latents_1step[b : b + 1]
             text_emb = (
                 text_embeddings[

diff --git a/threestudio/scripts/run_zero123_phase2.sh b/threestudio/scripts/run_zero123_phase2.sh
@@ -201,3 +201,19 @@ python launch.py --config configs/experimental/imagecondition_zero123nerf.yaml -
  system.weights="outputs/anya_front/Phase1/ckpts/last.ckpt" system.freq.guidance_eval=13 \
  system.loggers.wandb.enable=true system.loggers.wandb.project="claforte-anya-new-ph2" \
  data.image_path=./load/images/anya_front_rgba.png system.loggers.wandb.name="test20_use_Vikram_anya"
+
+# test21_use_Vikram_anya2_correct_image
+srun --account mod3d --partition=g40 --gpus=1 --job-name=3s_anya \
+python launch.py --config configs/experimental/imagecondition_zero123nerf.yaml --train \
+ system.prompt_processor.prompt="A DSLR 3D photo of a cute anime schoolgirl stands proudly with her arms in the air, pink hair ( unreal engine 5 trending on Artstation Ghibli 4k )" \
+ system.weights="outputs/anya_front/Phase1/ckpts/last.ckpt" system.freq.guidance_eval=13 \
+ system.loggers.wandb.enable=true system.loggers.wandb.project="claforte-anya-new-ph2" \
+ data.image_path=./load/images/anya_front_rgba.png system.loggers.wandb.name="test21_use_Vikram_anya2_correct_image"
+
+# test22_use_Vikram_anya3_finally_correct_image
+srun --account mod3d --partition=g40 --gpus=1 --job-name=3s_anya \
+python launch.py --config configs/experimental/imagecondition_zero123nerf.yaml --train \
+ system.prompt_processor.prompt="A DSLR 3D photo of a cute anime schoolgirl stands proudly with her arms in the air, pink hair ( unreal engine 5 trending on Artstation Ghibli 4k )" \
+ system.weights="outputs/anya_front/Phase1/ckpts/last.ckpt" system.freq.guidance_eval=13 \
+ system.loggers.wandb.enable=true system.loggers.wandb.project="claforte-anya-new-ph2" \
+ data.image_path=./load/images/anya_front_rgba.png system.loggers.wandb.name="test22_use_Vikram_anya3_finally_correct_image"
diff --git a/threestudio/systems/base.py b/threestudio/systems/base.py
@@ -309,7 +309,7 @@ def on_predict_end(self) -> None:
 
     def guidance_evaluation_save(self, comp_rgb, guidance_eval_out):
         B, size = comp_rgb.shape[:2]
-        max_items = self.cfg.guidance.max_items_to_save
+        max_items = self.cfg.guidance.max_items_eval
         if max_items == -1:
             max_items = B