Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load fixed custom mesh and train texture only. #221

Merged
merged 4 commits into from
Jul 18, 2023

Conversation

yankeesong
Copy link
Collaborator

Wrote a new module for training texture only.

@yankeesong yankeesong marked this pull request as draft July 10, 2023 17:52
@yankeesong yankeesong marked this pull request as ready for review July 10, 2023 18:01
@yankeesong yankeesong changed the title [DRAFT] Load fixed custom mesh and train texture only. Load fixed custom mesh and train texture only. Jul 11, 2023
Copy link
Collaborator

@bennyguo bennyguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except that we should discard the changes in the training config as addressed below.

@@ -85,10 +101,10 @@ system:
eps: 1.e-15

trainer:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert the changes in this section

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@bennyguo
Copy link
Collaborator

@yankeesong Sorry for the delay! Merging.

@bennyguo bennyguo merged commit 38f50c1 into threestudio-project:main Jul 18, 2023
1 check passed
@yankeesong yankeesong deleted the fixed_mesh branch August 23, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants