-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add move/copy-to-account #8632
base: main
Are you sure you want to change the base?
Add move/copy-to-account #8632
Conversation
The failing protocol tests might be because the tests were run using an (old?) JDK without an "unlimited cryptography policy". See https://www.java.com/en/configure_crypto.html The failing tests in In general it's probably best to use the same Java version our GitHub workflow is using. Currrently that's Java 17. |
I switched to Java 17 (I was using 21) and things got a little better. The *ServerSettingsValidatorTest tests no longer fail. The RealImapConnectionTest test still fails as well as the tests in QuoteDateFormatterTest. I am attaching the screenshots. |
Thanks for working on adding support for moving messages from one account to another ❤️ Unfortunately, the suggested change only works in the best case and doesn't support error handling and recovery at all. Mostly that's because the necessary infrastructure for that is not in place. I listed (some of) the things that need to be considered here: #760 (comment) There's a lot of changes we need to make to I don't think it would be reasonable to put all of the necessary changes in one pull request. So my recommendation is to close this pull request. |
Fixes issue #760.
The approach is fairly straightforward:
MessageStore.saveLocalMessage()
It doesn't break any tests as far as I can tell. There are 11 tests that fail on my computer, and they are the same tests that fail in the main branch. Screenshots attached.