Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions/Workflows housekeeping #96

Merged

Conversation

Lordfirespeed
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Dec 4, 2023

CLA assistant check
All committers have signed the CLA.

@Lordfirespeed
Copy link
Contributor Author

Related: #95

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9de949b) 5.59% compared to head (c18cd03) 5.47%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #96      +/-   ##
=========================================
- Coverage    5.59%   5.47%   -0.13%     
=========================================
  Files          42      42              
  Lines        2413    2413              
  Branches        0     237     +237     
=========================================
- Hits          135     132       -3     
  Misses       2278    2278              
- Partials        0       3       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@MythicManiac MythicManiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@MythicManiac
Copy link
Member

Seems like codecov might still fail due to codecov/feedback#126, but if everything else seems to pass I'll merge this PR as is

@MythicManiac MythicManiac merged commit adf0290 into thunderstore-io:master Dec 6, 2023
6 of 7 checks passed
@Lordfirespeed
Copy link
Contributor Author

Lordfirespeed commented Dec 6, 2023

Yeah, I believe the 'token' argument you've provided is the default, which is why I had removed it

Edit: oh! This is a codecov specific token. that is different to before :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants