Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App hassgraph: show lowest/highest in local time #2710

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ChaosKid42
Copy link
Contributor

App HASS Graph:

This PR makes the App show timestamps in local time instead of UTC

@vincentezw : Hope you like the idea.

@tidbyt
Copy link

tidbyt bot commented Sep 21, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of http.star requires review
🟡 Original Author The original author (vincentezw) does not match the PR author (ChaosKid42)

@vincentezw
Copy link
Contributor

vincentezw commented Sep 23, 2024

Great idea, and thank you for the PR! Being in my timezone, I hadn't considered this issue before. The PR looks good overall. However, I do wonder if we might skip the in_location call when no timezone has been configured, rather than defaulting to New York. This change could help avoid unexpected results for existing users who haven't set a timezone. That's just a suggestion, though!

@ChaosKid42
Copy link
Contributor Author

ChaosKid42 commented Sep 23, 2024

Great idea, and thank you for the PR! Being in my timezone, I hadn't considered this issue before. The PR looks good overall. However, I do wonder if we might skip the in_location call when no timezone has been configured, rather than defaulting to New York. This change could help avoid unexpected results for existing users who haven't set a timezone. That's just a suggestion, though!

Yes. Your are right. Better to not change the app's behaviour in case the location isn't set. I changed the PR accordingly.

@vincentezw: what do you think?

@vincentezw
Copy link
Contributor

@vincentezw: what do you think?

Awesome, thanks for adjusting that ❤️ . LGTM (we need to wait for Tidbyt to approve and merge though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants