Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Fireflies app. #2846

Merged
merged 12 commits into from
Nov 5, 2024
Merged

Update: Fireflies app. #2846

merged 12 commits into from
Nov 5, 2024

Conversation

jekeybl
Copy link
Contributor

@jekeybl jekeybl commented Oct 30, 2024

Consolidation of constants.
Enhanced code clarity and improved time-tracking accuracy within the firefly animation logic.

@tidbyt
Copy link

tidbyt bot commented Oct 30, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Automated Review Successful

Magical robots have reviewed your change and it looks good to go! 🤖

Test Details
App Dir All files are in a single app directory
Modules Only safe modules, without side-effects, are loaded
Original Author The original author matches the PR author

@jekeybl jekeybl marked this pull request as ready for review October 30, 2024 15:51
@matslina matslina merged commit 899a59d into tidbyt:main Nov 5, 2024
2 checks passed
@tidbyt tidbyt locked as resolved and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants