Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platform upload user list for jellyfish migration #297

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

platform upload user list for jellyfish migration #297

wants to merge 2 commits into from

Conversation

jh-bate
Copy link
Contributor

@jh-bate jh-bate commented Oct 9, 2024

@jh-bate jh-bate mentioned this pull request Oct 9, 2024
Open
darinkrauss
darinkrauss requested changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@darinkrauss darinkrauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider the rename, but definitely revert the docker-compose.yaml change (as we don't want to give any indication it is being used).

docker-compose.yml Outdated
@@ -183,6 +183,7 @@ services:
DISCOVERY_HOST: ${TIDEPOOL_DOCKER_HAKKEN_HOST}:8000
GATEKEEPER_SERVICE: '{"type": "static", "hosts": [{"protocol": "http", "host": "${TIDEPOOL_DOCKER_GATEKEEPER_HOST}:9123"}]}'
MINIMUM_UPLOADER_VERSION: '2.53.0'
PLATFORM_UPLOAD_USERS: ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can drop this. We don't support this and it needs to be deleted. The whole repo needs to be cleaned up.

charts/tidepool/charts/jellyfish/templates/0-configmap.yaml Outdated
@@ -11,4 +11,5 @@ data:
MinimumUploaderVersion: {{ .Values.configmap.data.MinimumUploaderVersion | default "2.53.0" }}
AuthRealm: {{ .Values.configmap.data.AuthRealm }}
AuthUrl: {{ .Values.configmap.data.AuthUrl }}
PlatformUploadUsers: {{ .Values.configmap.data.PlatformUploadUsers }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might call this UploaderPlatformUserIds and UPLOADER_PLATFORM_USER_IDS so it is clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darinkrauss darinkrauss darinkrauss requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jh-bate @darinkrauss