re-organize tool installation #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, tools were installed on the user's system, outside of the project directory, some into `npm --global prefix`, others in `GOPATH`. This can be annoying, as it can overwrite existing tools, or different projects with requirements on different versions of tools can conflict. The tools have been re-organized, so that they're all installed by the Makefile, and placed within the project directory. Specifically, go binaries are in tools/bin, and node scripts are in node_modules/.bin. The scripts have been edited to modify their paths to prefer the use of these project-specified tools, so that conflicts with other user-installed tools should be prevented. I also spent a little time doing some shell script cleanup, little things like quoting arguments, checking for required arguments and the like. Oh, and I versioned the go tools that were being installed. No one likes having those @latest surprises on a production deployment!
toddkazakov
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, tools were installed on the user's system, outside of the project directory, some into
npm --global prefix, others inGOPATH. This can be annoying, as it can overwrite existing tools, or different projects with requirements on different versions of tools can conflict.The tools have been re-organized, so that they're all installed by the Makefile, and placed within the project directory. Specifically, go binaries are in tools/bin, and node scripts are in node_modules/.bin. The scripts have been edited to modify their paths to prefer the use of these project-specified tools, so that conflicts with other user-installed tools should be prevented.
I also spent a little time doing some shell script cleanup, little things like quoting arguments, checking for required arguments and the like.
Oh, and I versioned the go tools that were being installed. No one likes having those @latest surprises on a production deployment!