set ExpiresAt in confirmations that support expiration #139
Conversation
ewollesen
force-pushed
the
eric/invitations-with-expiration
branch
2 times, most recently
from
5c78307
to
ba4c6ca
Compare
ewollesen
force-pushed
the
eric/invitations-with-expiration
branch
from
ba4c6ca
to
cab4964
Compare
Thanks @darinkrauss! Yes, there's a migration: https://github.com/tidepool-org/tools-private/pull/53 |
ewollesen
force-pushed
the
eric/invitations-with-expiration
branch
from
cab4964
to
6f56901
Compare
|
/deploy qa2 |
|
ewollesen updated values.yaml file in qa2 |
|
ewollesen updated flux policies file in qa2 |
|
ewollesen deployed hydrophone eric/invitations-with-expiration branch to qa2 namespace |
ewollesen
force-pushed
the
eric/invitations-with-expiration
branch
2 times, most recently
from
e4c1f44
to
900ebad
Compare
| @@ -232,12 +237,10 @@ func (c *Confirmation) ValidateType(expectedType Type, validationErrors *[]error | |||
| } | |||
|
|
|||
| func (c *Confirmation) IsExpired() bool { | |||
| timeout, ok := Timeouts[c.Type] | |||
| if !ok { | |||
| if c.ExpiresAt == nil || c.ExpiresAt.IsZero() { | |||
There was a problem hiding this comment.
[nit] Do we have zero time ExpiresAt in the the data currently? If not, then I'd remove the || c.ExpiresAt.IsZero() clause as not needed.
| t.Fatalf("expected nil error, got %s", err) | ||
| } | ||
| if nonExpiringInviting.IsExpired() { | ||
| t.Errorf("expected invitation type %q to never expire", cType) |
There was a problem hiding this comment.
Yes, much more self-explanatory than "expected false, got true". 👍
This field will help the care partner mobile app. BACK-2807
ewollesen
force-pushed
the
eric/invitations-with-expiration
branch
from
d5e51d6
to
aba6454
Compare
|
/deploy qa5 |
|
ewollesen updated values.yaml file in qa5 |
|
ewollesen updated flux policies file in qa5 |
|
ewollesen deployed hydrophone eric/invitations-with-expiration branch to qa5 namespace |
This field will help the care partner mobile app.
BACK-2807