Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLA signing and verification #26

Merged
merged 33 commits into from
Mar 5, 2024
Merged

Add CLA signing and verification #26

merged 33 commits into from
Mar 5, 2024

Conversation

cb1kenobi
Copy link
Contributor

@cb1kenobi cb1kenobi commented May 25, 2023

This PR adds the CLA form (or link to download signed CLA) to the Contributors page. In addition, it also provides a REST API endpoint for the CLA status check to verify that the user has signed the CLA. The signed PDF and metadata files are stored on Google Cloud Storage.

image

image

This PR also updates dependencies and cleans up global styles.

@cb1kenobi cb1kenobi marked this pull request as ready for review September 16, 2023 02:32
Copy link
Contributor

@m1ga m1ga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments

pages/index.tsx Outdated Show resolved Hide resolved
pages/index.tsx Outdated Show resolved Hide resolved
pages/blog/index.tsx Outdated Show resolved Hide resolved
utils/cla.ts Outdated Show resolved Hide resolved
utils/cla.ts Outdated Show resolved Hide resolved
utils/cla.ts Outdated Show resolved Hide resolved
utils/cla.ts Outdated Show resolved Hide resolved
@cb1kenobi cb1kenobi requested a review from m1ga September 17, 2023 04:47
@m1ga
Copy link
Contributor

m1ga commented Sep 17, 2023

Just a quick thought:

Maybe add another div around the pages in contribute.tsx line195 and make it height:700px, overflow:auto;border-radius:5px ?

Screenshot_20230917_114741

@cb1kenobi
Copy link
Contributor Author

I tried setting a height and it was horrible on mobile.

@m1ga
Copy link
Contributor

m1ga commented Sep 17, 2023

you can use something like 80vh so it will be 80% of the viewport height in combination with min-height: 500px to give it a minimum in case you use your phone horizontal.

@cb1kenobi
Copy link
Contributor Author

I don't agree with the border radius. It's unnecessary.

I don't agree with the capping the height. Like I implied, I already went down this road. Scrolling complicates UX. it complicates printing. It complicates the mobile experience. I wouldn't be surprised if if the scrolling complicated the overlayed field scaling. Remember, this is an agreement page. It's not a PDF viewer.

@m1ga
Copy link
Contributor

m1ga commented Sep 17, 2023

you are right, was overthinking it 😄 Should be quickly for the user and not make more steps then needed 👍

@cb1kenobi cb1kenobi marked this pull request as draft February 27, 2024 08:50
@cb1kenobi cb1kenobi mentioned this pull request Feb 28, 2024
@cb1kenobi
Copy link
Contributor Author

Here's the PR for the CLA action that uses the new API endpoint: tidev/tidev-cla-action#3.

@cb1kenobi cb1kenobi marked this pull request as ready for review March 4, 2024 04:12
@cb1kenobi
Copy link
Contributor Author

Let's go!

@cb1kenobi cb1kenobi merged commit 4238608 into main Mar 5, 2024
1 check passed
@cb1kenobi cb1kenobi deleted the cla branch March 5, 2024 05:45
@cb1kenobi cb1kenobi restored the cla branch March 5, 2024 05:45
@cb1kenobi cb1kenobi deleted the cla branch March 5, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants