-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLA signing and verification #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments
I tried setting a height and it was horrible on mobile. |
you can use something like |
I don't agree with the border radius. It's unnecessary. I don't agree with the capping the height. Like I implied, I already went down this road. Scrolling complicates UX. it complicates printing. It complicates the mobile experience. I wouldn't be surprised if if the scrolling complicated the overlayed field scaling. Remember, this is an agreement page. It's not a PDF viewer. |
you are right, was overthinking it 😄 Should be quickly for the user and not make more steps then needed 👍 |
Here's the PR for the CLA action that uses the new API endpoint: tidev/tidev-cla-action#3. |
Let's go! |
This PR adds the CLA form (or link to download signed CLA) to the Contributors page. In addition, it also provides a REST API endpoint for the CLA status check to verify that the user has signed the CLA. The signed PDF and metadata files are stored on Google Cloud Storage.
This PR also updates dependencies and cleans up global styles.