feat(ios): expose Ti.UI.Window.largeTitleAttributes #13896
Conversation
merge tidev master into max87 kotlin_1810
Kotlin 1810
hansemannn
changed the title
There was a problem hiding this comment.
A few styling changes, nothing critical! Once changed, I can help with adding the docs. Finally, can you please follow these steps to sign our contribution agreement? It's only necessary once, after that we can merge your changes much faster. Code strong! :)
android/modules/network/src/java/ti/modules/titanium/network/TiHTTPClient.java
Outdated
Show resolved
Hide resolved
iphone/TitaniumKit/TitaniumKit/Sources/Modules/TiUIWindowProxy.m
Outdated
Show resolved
Hide resolved
android/modules/network/src/java/ti/modules/titanium/network/TiHTTPClient.java
Outdated
Show resolved
Hide resolved
fix(ios): removed bounce from TiAnimation feat(android): Added collapse_toolbar props
|
Yeah, I removed it, because my local build failed on it... Now it builded fine |
|
you still have some parts of the other PR in your PR and you've changed some Android layouts. It's always better to work in a different branch and not in master |
|
can you please discard this PR? I merged newest code from GA to my custom SDK, that's why there is android layout(about collapse toolbar) |
|
sure, you can always close it (there is a button at the bottom) and create a new one. Or clean it up. Up to you 😄 |
Use largeTitleAttributes similar to titleAttributes which applies custom style to window's title.
titleAttributes applies style to scrolled title(in navBar) only, largeTitleAttributes to big one only