Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(win): permission issues when building a module #14078

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(win): permission issues when building a module #14078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions cli/commands/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,8 +420,13 @@ function patchLogger(logger, cli) {

fs.ensureDirSync(buildDir, 0o766);

// create our write stream
logger.log.filestream = fs.createWriteStream(path.join(buildDir, 'build_' + platform + '.log'), { flags: 'w', encoding: 'utf8', mode: 0o666 });
if (process.platform === 'win32' && cli.argv.type === 'module') {
// disable file logging for windows when building a module
logger.fileWriteEnabled = false;
} else {
// create our write stream
logger.log.filestream = fs.createWriteStream(path.join(buildDir, 'build_' + platform + '.log'), { flags: 'w', encoding: 'utf8', mode: 0o666 });
}

function styleHeading(s) {
return ('' + s).bold;
Expand Down
Loading