-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: new control Ti.UI.BottomNavigation #14126
base: master
Are you sure you want to change the base?
Conversation
Can't you replace the old tab group API with the newer API internally? I do not see iOS implementing the same API as it already has, as it's the same. Ideally, this change would only swap the internal UI behind Ti.UI.TabGroup while retaining the API structure. Legacy things like the |
android/modules/ui/src/java/ti/modules/titanium/ui/TabGroupProxy.java
Outdated
Show resolved
Hide resolved
Pushed my current WIP where I use the old structure and you can use var bottomNav = Ti.UI.createTabGroup({
tabs: [tab1, tab2],
experimental:true, // <- new
style: Ti.UI.Android.TABS_STYLE_BOTTOM_NAVIGATION
}); to use the new XML layout. I'm working on it at the moment 😄 |
android/modules/ui/src/java/ti/modules/titanium/ui/widget/tabgroup/TiUIAbstractTabGroup.java
Show resolved
Hide resolved
icon can now use Bildschirmaufnahme_20241015_192941.mp4(demo icon from https://shapeshifter.design/ ) |
As I would love to get this out for people to use I've added some docs and examples how to use it. Note:As the We are doing this with Once we are ready to ship a SDK with breaking changes AND we have gathered feedback by people who opt-in already and used the features we can switch them on by default. Thoughts about this? |
|
I'll change the property to
|
Work in progress
Just a test for now.
Currently working:
indicatorColor
that allows you to set the color of the M3 ItemActiveIndicatorColorBildschirmaufnahme_20241002_231752.webm
Current issues: