Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): add direction to ListView scrolling #14130

Merged
merged 6 commits into from
Oct 5, 2024
Merged

feat(ios): add direction to ListView scrolling #14130

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a7ac1d4
feat(ios): add direction to ListView scrolling
m1ga Oct 3, 2024
6f7e07c
Update iphone/Classes/TiUIListView.m
m1ga Oct 5, 2024
24acf7e
fix: fix “direction” event attribute default
hansemannn Oct 5, 2024
d109bb5
fix: fix incorrect type
hansemannn Oct 5, 2024
e50586b
chore: align “unknown” value with Android, update docs
hansemannn Oct 5, 2024
1551e8d
Merge branch 'master' into iosScrollingDirection
m1ga Oct 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions iphone/Classes/TiUIListView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ @interface TiUIListView ()
@property (nonatomic, readonly) TiUIListViewProxy *listViewProxy;
@property (nonatomic, copy, readwrite) NSString *searchString;
@property (nonatomic, copy, readwrite) NSString *searchedString;
@property (nonatomic, assign) CGFloat lastContentOffset;
@end

static TiViewProxy *FindViewProxyWithBindIdContainingPoint(UIView *view, CGPoint point);
Expand Down Expand Up @@ -2011,6 +2012,15 @@ - (void)scrollViewDidScroll:(UIScrollView *)scrollView
TiUIListSectionProxy *section;
CGFloat topSpacing = scrollView.contentOffset.y + scrollView.adjustedContentInset.top;

NSString *direction = [NSNull null];
m1ga marked this conversation as resolved.
Show resolved Hide resolved

if (self.lastContentOffset > scrollView.contentOffset.y) {
direction = @"down";
} else if (self.lastContentOffset < scrollView.contentOffset.y) {
direction = @"up";
}
self.lastContentOffset = scrollView.contentOffset.y;

if ([indexPaths count] > 0) {
NSIndexPath *indexPath = [self pathForSearchPath:[indexPaths objectAtIndex:0]];
NSUInteger visibleItemCount = [indexPaths count];
Expand All @@ -2022,6 +2032,7 @@ - (void)scrollViewDidScroll:(UIScrollView *)scrollView
[eventArgs setValue:section forKey:@"firstVisibleSection"];
[eventArgs setValue:[section itemAtIndex:[indexPath row]] forKey:@"firstVisibleItem"];
[eventArgs setValue:NUMINTEGER(topSpacing) forKey:@"top"];
[eventArgs setValue:direction forKey:@"direction"];

if (lastVisibleItem != [indexPath row] || lastVisibleSection != [indexPath section] || forceUpdates) {
// only log if the item changes or forced
Expand All @@ -2038,6 +2049,7 @@ - (void)scrollViewDidScroll:(UIScrollView *)scrollView
[eventArgs setValue:section forKey:@"firstVisibleSection"];
[eventArgs setValue:NUMINTEGER(-1) forKey:@"firstVisibleItem"];
[eventArgs setValue:NUMINTEGER(topSpacing) forKey:@"top"];
[eventArgs setValue:direction forKey:@"direction"];
}
});
}
Expand Down
Loading